Cisco n1kv plugin missing subnet check on network delete

Bug #1336107 reported by Steven Hillman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Marga Millet
Icehouse
New
Undecided
Unassigned

Bug Description

N1kv plugin should raise an exception during network delete if there is a subnet that is tied to that network.

Changed in neutron:
assignee: nobody → Steven Hillman (sthillma)
tags: added: api cisco
Changed in neutron:
importance: Undecided → Medium
status: New → Confirmed
Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/111349

Changed in neutron:
assignee: Steven Hillman (sthillma) → Marga (millet)
Changed in neutron:
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/111349
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=89fb8b633b1ae34d0b56d73ee115462f4acc9540
Submitter: Jenkins
Branch: master

commit 89fb8b633b1ae34d0b56d73ee115462f4acc9540
Author: Marga Millet <email address hidden>
Date: Fri Aug 1 10:41:45 2014 -0700

    Raise exception for network delete with subnets presents

    N1kv plugin should raise an exception during network delete
    if there is a subnet that is tied to that network.

    Changed the order of the Assert arguments since now it's encoraged to have <expected_value, actual_value> now.

    Change-Id: I92f177af0e2a2fbc460e0d668989ce590b7d1cb2
    Closes-Bug: 1336107

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/114429

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/114429
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=534bfbc05e28edfb5907a53dc5265086e1c609a4
Submitter: Jenkins
Branch: stable/icehouse

commit 534bfbc05e28edfb5907a53dc5265086e1c609a4
Author: Marga Millet <email address hidden>
Date: Fri Aug 1 10:41:45 2014 -0700

    Raise exception for network delete with subnets presents

    N1kv plugin should raise an exception during network delete
    if there is a subnet that is tied to that network.

    Also changed the order of the assert arguments since now
    it's encoraged to have <expected_value, actual_value>.

    PLEASE NOTE:
    This is a port to icehouse branch. It looks like there are extra test
    cases not relevant to the fix. However, they are need it because:
    - the code I've commited in delete_network() changes the behavior and
      it'll fail when we try to delete a network if there are subnets on it.
    - hence all the test cases which tries to delete a network and don't
      delete the subnets first, will fail.
    - Hence ALL the test cases in test_db_plugin.py file which does that
      (deleting the network without deleting the subnet first), needs to
      be overriding and this is why you see all these test cases which
      seems to not be related with the diffs in n1kv_neutron_plugin.py
      file but they are actually very related.

    Conflicts:
     neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py

    Closes-Bug: 1336107
    (cherry picked from commit 89fb8b633b1ae34d0b56d73ee115462f4acc9540)
    Change-Id: I92f177af0e2a2fbc460e0d668989ce590b7d1cb2

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.