neutron

TypeError while building routers

  1. Series icehouse
  2. Bug #1309144
Bug #1309144 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Armando Migliaccio
neutron 2014.2 "juno"
Havana
Fix Released
Undecided
Unassigned
neutron 2013.2.4
Icehouse
New
Undecided
Unassigned

Bug Description

This stacktrace:

2014-04-17 09:37:06.460 10212 ERROR neutron.openstack.common.loopingcall [req-512e4936-b85a-4019-bc2c-e1b8faf4c8c5 None] in dynamic looping call
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall Traceback (most recent call last):
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall File "/opt/stack/neutron/neutron/openstack/common/loopingcall.py", line 123, in _inner
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall idle = self.f(*self.args, **self.kw)
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall File "/opt/stack/neutron/neutron/plugins/vmware/common/sync.py", line 647, in _synchronize_state
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall scan_missing=scan_missing)
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall File "/opt/stack/neutron/neutron/plugins/vmware/common/sync.py", line 401, in _synchronize_lrouters
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall filters=filters)
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall File "/opt/stack/neutron/neutron/db/db_base_plugin_v2.py", line 195, in _get_collection
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall items = [dict_func(c, fields) for c in query]
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall File "/opt/stack/neutron/neutron/db/l3_db.py", line 106, in _make_router_dict
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall nw_id = router.gw_port['network_id']
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall TypeError: 'NoneType' object has no attribute '__getitem__'
2014-04-17 09:37:06.460 10212 TRACE neutron.openstack.common.loopingcall

has been observed during this run:

http://208.91.1.172/logs/neutron/82709/9/412384/

Armando Migliaccio (armando-migliaccio)
Changed in neutron:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This looks like to be a common issue:

http://logstash.openstack.org/index.html#eyJzZWFyY2giOiJtZXNzYWdlOlwibndfaWQgPSByb3V0ZXIuZ3dfcG9ydFsnbmV0d29ya19pZCddXCIgQU5EIGZpbGVuYW1lOlwibG9ncy9zY3JlZW4tcS1zdmMudHh0XCIgYW5kIG1lc3NhZ2U6XCJpbiBfZ2V0X2NvbGxlY3Rpb25cIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTM5Nzg0MjU3Nzc3OSwibW9kZSI6IiIsImFuYWx5emVfZmllbGQiOiIifQ==

tags: removed: vmware
summary: - NSX: stacktrace during sync process
+ TypeError while building routers
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug report is relevant: #1064235.

The fix proposed there pulls the object explicitly. I'd suggest to change the lazy loading policy to 'joined', which in return should have a performance benefit too.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88665

Changed in neutron:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/88668

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/88669

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/88665
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=966dbb5368d710e2652b18f5b9cb4295f58598da
Submitter: Jenkins
Branch: master

commit 966dbb5368d710e2652b18f5b9cb4295f58598da
Author: armando-migliaccio <email address hidden>
Date: Fri Apr 18 12:32:26 2014 -0700

    gw_port should be set as lazy='join'

    This forces the object to be ready ahead of accessing time.
    The change in loading behavior is also beneficial while listing
    routers, as reduces the amount of queries being issued. Tests
    show a performance gain of 15-30% for router-list times.

    As Mr. Aaron Rosen is used to saying: Woot woot!!

    Closes-bug: #1309144

    Change-Id: Ibae261b91de26ca7c50e3f6c80e9be2a799785a3

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/88668
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8991aa60a986276d7592fe40c2c61468e638a486
Submitter: Jenkins
Branch: stable/icehouse

commit 8991aa60a986276d7592fe40c2c61468e638a486
Author: armando-migliaccio <email address hidden>
Date: Fri Apr 18 12:32:26 2014 -0700

    gw_port should be set as lazy='join'

    This forces the object to be ready ahead of accessing time.
    The change in loading behavior is also beneficial while listing
    routers, as reduces the amount of queries being issued. Tests
    show a performance gain of 15-30% for router-list times.

    As Mr. Aaron Rosen is used to saying: Woot woot!!

    Closes-bug: #1309144

    Change-Id: Ibae261b91de26ca7c50e3f6c80e9be2a799785a3
    (cherry picked from commit 966dbb5368d710e2652b18f5b9cb4295f58598da)

tags: added: in-stable-icehouse
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/88669
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=828c74623c86789adde3206aa6277dd5fab4e9a7
Submitter: Jenkins
Branch: stable/havana

commit 828c74623c86789adde3206aa6277dd5fab4e9a7
Author: armando-migliaccio <email address hidden>
Date: Fri Apr 18 12:32:26 2014 -0700

    gw_port should be set as lazy='join'

    This forces the object to be ready ahead of accessing time.
    The change in loading behavior is also beneficial while listing
    routers, as reduces the amount of queries being issued. Tests
    show a performance gain of 15-30% for router-list times.

    As Mr. Aaron Rosen is used to saying: Woot woot!!

    Closes-bug: #1309144

    Change-Id: Ibae261b91de26ca7c50e3f6c80e9be2a799785a3
    (cherry picked from commit 966dbb5368d710e2652b18f5b9cb4295f58598da)

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.