User-visible messages are not localizable

Fix proposed to branch: master
Review: https://review.openstack.org/6606

I was looking at this bug recently. I found there are so many user-visible strings are not localizable. It will be a huge commit to fix this bug and it's hard for reviewing. I hope we can fix this bug in a blueprint so that we can fix this bug step by step.

Any comments ??

On 10/25/2012 05:45 AM, Jiajun Liu wrote:
> I was looking at this bug recently. I found there are so many user-
> visible strings are not localizable. It will be a huge commit to fix
> this bug and it's hard for reviewing. I hope we can fix this bug in a
> blueprint so that we can fix this bug step by step.
>
> Any comments ??
>
Hi,
A blueprint is a good idea. The best practice would be to do a number of
small isolated patches. This could also help spread the load.
Thanks
Gary

Yes, agree on the smaller change sets.

And this would need to be combined with a push to educate core
reviewers to no longer allow in new changes unless strings are
localizable, otherwise we'll be perpetually needing to clean-up.

dan

On Wed, Oct 24, 2012 at 11:42 PM, Gary Kotton <email address hidden> wrote:
> On 10/25/2012 05:45 AM, Jiajun Liu wrote:
>> I was looking at this bug recently. I found there are so many user-
>> visible strings are not localizable. It will be a huge commit to fix
>> this bug and it's hard for reviewing. I hope we can fix this bug in a
>> blueprint so that we can fix this bug step by step.
>>
>> Any comments ??
>>
> Hi,
> A blueprint is a good idea. The best practice would be to do a number of
> small isolated patches. This could also help spread the load.
> Thanks
> Gary
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/938393
>
> Title:
> User-visible messages are not localizable
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> Strings in Quantum are not defined with gettext (_()) and are not
> localizable. In keeping with the standard set by the rest of
> Openstack, all user-visible strings in the codebase will need to be
> internationalized.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/938393/+subscriptions

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~

all right. I will make proposal about which strings should be localized and how to do that soon.

I proposaled a blueprint make-string-localizable for this bug.
https://blueprints.launchpad.net/quantum/+spec/make-string-localizable
any comments are welcome.

Closing bug as the work has been completed under this blueprint: https://blueprints.launchpad.net/quantum/+spec/make-string-localizable