neutron

prune files with poor code coverage

Bug #877120 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Zhongyue Luo
neutron 2013.1 "grizzly"

Bug Description

There are a set of common file that have poor code coverage, presumably because they have a lot of unused code copied from other projects. We should prune these files to eliminate unused code:

quantum.common.config 33 11 2 1 66% 72-73, 82-86, 104-108

quantum.common.constants 8 8 0 0 0% 16-24

quantum.common.rpc 17 9 4 0 57% 32-40

quantum.common.utils 71 15 40 4 83% 40-48, 83-84, 109-112, 123

See original description
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Pruning unused code is one of things I'm doing as a part of api-framework-essex (https://blueprints.launchpad.net/quantum/+spec/api-framework-essex).

Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
Revision history for this message
dan wendlandt (danwent) wrote :

This is related to the drive to move code to openstack-common (but eliminating code is even better!). I'd like to revisit this when we can spend some time on code coverage (hopefully at the start of E-4)

Changed in quantum:
importance: Undecided → Medium
Revision history for this message
dan wendlandt (danwent) wrote :

removing assignee, adding low-hanging-fruit.

this would still be valuable, so anyone with cycles, please take a look!

Changed in quantum:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
dan wendlandt (danwent)
Changed in quantum:
status: New → Confirmed
Revision history for this message
Gary Kotton (garyk) wrote :

Is this bug still relevant? A lot has been done over the last few weeks to remove unused functions from quantum.common.utils and quantum.common.config.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Assigning to myself for triaging and then either i) close it or ii) address it.

Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
Zhongyue Luo (zyluo)
description: updated
description: updated
Changed in quantum:
assignee: Salvatore Orlando (salvatore-orlando) → Zhongyue Luo (zyluo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17334

Changed in quantum:
status: Confirmed → In Progress
Gary Kotton (garyk)
Changed in quantum:
importance: Medium → Wishlist
importance: Wishlist → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/17334
Committed: http://github.com/openstack/quantum/commit/e4ee84f008405c85ed2700f275e4538ada099b69
Submitter: Jenkins
Branch: master

commit e4ee84f008405c85ed2700f275e4538ada099b69
Author: Zhongyue Luo <email address hidden>
Date: Mon Dec 3 15:45:51 2012 +0800

    Removes unused code in quantum.common

    Removed boolize() in quantum.common.utils

    Fixes bug #877120

    Change-Id: Icb30b4200baf8743bbee6b4dd035c8b316c38533

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.