neutron

[neutron-api] remove leader_only for maintenance worker

Bug #2022914 reported by Maxim Korezkij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
In Progress
Medium
Maxim Korezkij

Bug Description

Currently if you want to connect the neutron-api to the souhtbound database you cannot use relays, because the maintenance worker has a condition set that it requires a leader_only connection.

This leader_only collection is not necessary since the maintenance tasks of the neutron-api are only getting information from the souhtbound and are not pushing information into the souhtbound database.

If you adjust the neutron-api to use relays, it will log something like "relay database, cannot be leader" every time the maintenance task should run.

I would expect to be able to set the southbound connection for the neutron-api to use the relays.

OpenStack Infra (hudson-openstack)
Changed in neutron:
status: New → In Progress
Bernard Cafarelli (bcafarel)
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Maxim Korezkij (maximkorezkij)
summary: - [neutron-api] remove leader_only for maitenance worker
+ [neutron-api] remove leader_only for maintenance worker
tags: added: ovn
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Patch: https://review.opendev.org/c/openstack/neutron/+/885240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b3

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/894783

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/894784

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889807
Committed: https://opendev.org/openstack/neutron/commit/f0abced1c94665142100e2b53fa398ebad8e5f01
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit f0abced1c94665142100e2b53fa398ebad8e5f01
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889817
Committed: https://opendev.org/openstack/neutron/commit/a34549294c13f6528399cd2b0af24b0be080c6e5
Submitter: "Zuul (22348)"
Branch: stable/zed

commit a34549294c13f6528399cd2b0af24b0be080c6e5
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889804
Committed: https://opendev.org/openstack/neutron/commit/580027b7c9f12e005a93a3aae378c486f50cc642
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 580027b7c9f12e005a93a3aae378c486f50cc642
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894783
Committed: https://opendev.org/openstack/neutron/commit/067364fce50ca4105b3a98f9838d7fecc8e6baec
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 067364fce50ca4105b3a98f9838d7fecc8e6baec
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894784
Committed: https://opendev.org/openstack/neutron/commit/9869029aef1dafca4637aaf43f587ce4799cade4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9869029aef1dafca4637aaf43f587ce4799cade4
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

tags: added: in-stable-wallaby
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.