neutron

Deprecate and remove any "ofctl" code in Neutron and related projects

Bug #1853171 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-sfc
New
Undecided
Unassigned
neutron
In Progress
Medium
Unassigned

Bug Description

This bug should track all changes related to deprecate and remove all "ofctl" CLI application code in Neutron and related projects (e.g.: networking-sfc).

Base function that should be removed: https://github.com/openstack/neutron/blob/0fa7e74ebb386b178d36ae684ff04f03bdd6cb0d/neutron/agent/common/ovs_lib.py#L343

Any Open Flow call should use the native implementation, using os-ken library.

Tags: qos ofctl
Revision history for this message
Miguel Lavalle (minsel) wrote :

FWIW, there is not a lot to remove: http://codesearch.openstack.org/?q=run_ofctl&i=nope&files=&repos=.

Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
LIU Yulong (dragon889) wrote :

Openflow based firewall relies on this 'ofctl' command for some match&action rule like reg5 and reg6 of NX. We have the alternative implementation now? IMO, we should have the new approach first, then start the deprecate procedure of old way.

David Shaughnessy (david-shaughnessy)
Changed in neutron:
assignee: nobody → David Shaughnessy (david-shaughnessy)
OpenStack Infra (hudson-openstack)
Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
David Shaughnessy (david-shaughnessy) wrote :

@ LIU yup, you are able to set and match on reg5 and reg6.
For deprecation we've just added debtcollector to the start of the function call.
Here is the patch: https://review.opendev.org/#/c/695479

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/695479
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b81155ee27d918ba934ee7f08cb70d76715a2163
Submitter: Zuul
Branch: master

commit b81155ee27d918ba934ee7f08cb70d76715a2163
Author: David Shaughnessy <email address hidden>
Date: Thu Nov 21 13:25:58 2019 +0000

    Migrate from ofctl to native QoS DSCP

    Neutron migrated from using ofctl from the command line in Pike.
    This patch refactors DSCPs OvS backend to use native rather than
    ofctl and deprecates the run_ofctl function in ovs_lib.OVSBridge.

    Change-Id: Id9ab0eaf92b6ec6d5c9197bee60d324ffcb192a8
    Related-Bug: #1853171

Rodolfo Alonso (rodolfo-alonso-hernandez)
tags: added: qos
tags: added: ofctl
Revision history for this message
Lajos Katona (lajos-katona) wrote :

I am happy to deal with networking-bagpipe, though I have to learn this area

Revision history for this message
Lajos Katona (lajos-katona) wrote :

As I see the code path that still uses run_ofctl in networking-bagpipe is related to the networking-sfc driver.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/711949

David Shaughnessy (david-shaughnessy)
Changed in neutron:
assignee: David Shaughnessy (david-shaughnessy) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.opendev.org/711949
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.