quark

Some tests use assertEqual(observed, expected) , the argument order is wrong

Bug #1259292 reported by Clint Byrum on 2013-12-09

This bug affects 7 people

	Status	Importance	Assigned to	Milestone
Astara	Fix Released	Undecided	Ji.Wei
Bandit	Fix Released	Undecided	Jeremy Liu
Barbican	Fix Released	Wishlist	Jeremy Liu
Blazar	Fix Released	Wishlist	Unassigned
Ceilometer	Invalid	Undecided	Mark Korondi
Cinder	Fix Released	Wishlist	Nate Potter
Designate	Fix Released	Undecided	sonu
Glance	Fix Released	Undecided	Rajesh Tailor
Glance Client	Fix Released	Undecided	Vstorage_ZTE
Higgins	New	Undecided	Unassigned
Magnum	Fix Released	Undecided	lei zhang	Magnum mitaka-1
Mistral	Fix Released	Low	Hardik Parekh	Mistral 1.0.0 "liberty"
Murano	Fix Released	Low	Tatiana Kholkina	Murano mitaka-1 "m1"
OpenStack Backup/Restore and DR (Freezer)	In Progress	Low	Unassigned
OpenStack Compute (nova)	Won't Fix	Wishlist	Unassigned
OpenStack Dashboard (Horizon)	Fix Released	Wishlist	Tuan	OpenStack Dashboard (Horizon) queens-1
OpenStack Identity (keystone)	Fix Released	Wishlist	jingtao liang	OpenStack Identity (keystone) mitaka-1 "m1"
OpenStack Shared File Systems Service (Manila)	Fix Released	Low	Yusuke Hayashi
PBR	Fix Released	Undecided	weiweigu
Python client library for Zaqar	Fix Released	Undecided	Md Nadeem	Python client library for Zaqar 0.3.0 "0.3.0"
Rally	In Progress	Low	sudhir agarwal
SWIFT	In Progress	Undecided	Nick Miethe
Sahara	Fix Released	Undecided	Jacob Bin Wang	Sahara 2015.1.0 "kilo"
Solum	Fix Released	Undecided	Yafei Yu
congress	Fix Released	Undecided	Anusha	congress 3.0.0
daisycloud-core	New	Undecided	Unassigned
glance_store	Fix Released	Low	Yafei Yu
networking-calico	Fix Released	Undecided	Yan Songming
networking-infoblox	In Progress	Undecided	hongzhezheng
networking-l2gw	Fix Released	Undecided	qinchunhua
networking-sfc	Fix Released	Undecided	Yan Songming
os-brick	Fix Released	Wishlist	Yafei Yu
pycadf	Fix Released	Low	jingtao liang
python-barbicanclient	Fix Released	Undecided	Jeremy Liu
python-ceilometerclient	Invalid	Low	Unassigned
python-cinderclient	Fix Released	Undecided	Kiyohiro Adachi	python-cinderclient 1.3.1 "1.3.1"
python-designateclient	Fix Released	Undecided	sonu
python-mistralclient	Fix Released	Undecided	Hardik Parekh
python-solumclient	Fix Released	Undecided	Unassigned
quark	In Progress	Undecided	sudhir agarwal
sqlalchemy-migrate	In Progress	Undecided	Anishka Gupta
tacker	Fix Released	Undecided	JianGang Weng
tempest	Invalid	Undecided	Unassigned
zaqar	Fix Released	Undecided	Md Nadeem

Bug Description

The test cases will produce a confusing error message if the tests ever fail, so this is worth fixing.

Tags:

Pavlo Shchelokovskyy (pshchelo) on 2013-12-09

Changed in heat:
assignee:	nobody → Pavlo Shchelokovskyy (pshchelo)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-11: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61457

Changed in heat:
status:	Triaged → In Progress

Pavlo Shchelokovskyy (pshchelo) on 2013-12-25

Changed in python-heatclient:
assignee:	nobody → Pavlo Shchelokovskyy (pshchelo)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-25: Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64039

Changed in python-heatclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-30: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64415

Guangya Liu (Jay Lau) (jay-lau-513) on 2013-12-31

Changed in nova:
assignee:	nobody → Jay Lau (jay-lau-513)
importance:	Undecided → Low

Guangya Liu (Jay Lau) (jay-lau-513) on 2013-12-31

no longer affects:

nova

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-01-24: Fix merged to heat (master)

Reviewed: https://review.openstack.org/64415
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=240fec9eef800a53aec890ce9ba14b4d07f136d5
Submitter: Jenkins
Branch: master

commit 240fec9eef800a53aec890ce9ba14b4d07f136d5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Dec 30 11:15:54 2013 +0200

Fix order of arguments in assertEqual (patch 2/2)

Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is
assertEqual(expected, observed).

This patch includes the other half of the files touched by these changes
(starting from test_n* plus contrib code) to ease the review.

Change-Id: I870386871581980abd796304dd91be0c662cb73e
Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-01-27:

Reviewed: https://review.openstack.org/61457
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=499b7cccac96e134941dc1e6cd84afe41302fce5
Submitter: Jenkins
Branch: master

commit 499b7cccac96e134941dc1e6cd84afe41302fce5
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Dec 11 17:15:54 2013 +0200

Fix order of arguments in assertEqual (patch 1/2)

Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is
assertEqual(expected, observed).

This patch includes roughly half of the files touched by these changes
(up to and including test_m* sans contrib code) to ease the review.

Partial-Bug: #1259292

Change-Id: I44bff827c7c50726d48aa649b7685712a233ee62

Revision history for this message

Andrew Lazarev (alazarev) wrote on 2014-01-29:

Could you point on doc that says that correct order of parameters is "expected, observed"? This is true for java junit. I was trying to find the same doc for testtools, but didn't success. Moreover official doc for python unittest (http://docs.python.org/2/library/unittest.html) says the opposite (yes, it is not testtools, but anyway).

Revision history for this message

Steve Baker (steve-stevebaker) wrote on 2014-01-29:

Look at the message that testtools builds for assertEquals fails.

Steve Baker (steve-stevebaker) on 2014-02-17

Changed in python-heatclient:
importance:	Undecided → Low
milestone:	none → v0.2.7
milestone:	v0.2.7 → v0.2.8

Revision history for this message

Kiyohiro Adachi (adachi) wrote on 2014-02-21:

In 'assertEqual(expected, observed)', the string length of the sum of the results of repr(expected) and repr(observed) is greater than 70, then, MismatchError message is changed. Depending on the length of repr(observed), this condition is satisfied.

https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_basic.py#L77

Changed in cinder:
assignee:	nobody → Kiyohiro Adachi (adachi)

lvdongbing (dbcocle) on 2014-02-21

Changed in ceilometer:
assignee:	nobody → lvdongbing (dbcocle)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-21: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/75357

Changed in cinder:
status:	New → In Progress

Kiyohiro Adachi (adachi) on 2014-02-25

Changed in python-cinderclient:
assignee:	nobody → Kiyohiro Adachi (adachi)

John Griffith (john-griffith) on 2014-02-25

Changed in cinder:
importance:	Undecided → Low

Revision history for this message

John Griffith (john-griffith) wrote on 2014-02-25:

#10

I don't see much value in this and honestly it seems rather silly to go through the effort. It happens that testtools does in fact use the ordering you prefer in their examples, however many other frameworks document using the exact opposite. In reality I don't see what it really matters or what the benefit is.

I don't speak for other projects but from Cinder's perspective this is not something I would want to see proposed for this stage of the release. If you want to go through and change this when Juno opens up and propose for Cinder at that time I suppose that's fine, but right now I'd rather people didn't spend time reviewing changes like this.

Changed in cinder:
importance:	Low → Wishlist
importance:	Wishlist → Low

lvdongbing (dbcocle) on 2014-02-26

Changed in ceilometer:
assignee:	lvdongbing (dbcocle) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-26: Fix proposed to python-cinderclient (master)

#11

Fix proposed to branch: master
Review: https://review.openstack.org/76453

Changed in python-cinderclient:
status:	New → In Progress

Steve Baker (steve-stevebaker) on 2014-03-02

Changed in python-heatclient:
milestone:	v0.2.8 → v0.2.9

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2014-03-03: Re: [Bug 1259292] Re: Some tests use assertEqual(observed, expected) , the argument order is wrong

#12

Excerpts from John Griffith's message of 2014-02-25 23:47:08 UTC:
> I don't see much value in this and honestly it seems rather silly to go
> through the effort. It happens that testtools does in fact use the
> ordering you prefer in their examples, however many other frameworks
> document using the exact opposite. In reality I don't see what it
> really matters or what the benefit is.
>
> I don't speak for other projects but from Cinder's perspective this is
> not something I would want to see proposed for this stage of the
> release. If you want to go through and change this when Juno opens up
> and propose for Cinder at that time I suppose that's fine, but right now
> I'd rather people didn't spend time reviewing changes like this.
>

Hi John. The trouble happens when the tests fail, and it tells you the
opposite of reality. This isn't about the examples, it is about the text
of the failure report.

Unit tests are meant to help debug situations where a developer has
misunderstood complex inner workings of things. So if we also tell
them that we observed what they expect in the test, and expect what was
observed and what was also wrong, we are just decreasing the value of
the unit tests.

I agree that early in dev cycles is a better time for low priority issues,
and this is a low priority, but it is not a low value.

ChenZheng (chen-zheng) on 2014-03-03

Changed in horizon:
assignee:	nobody → ChenZheng (chen-zheng)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-03-03: Fix proposed to horizon (master)

#13

Fix proposed to branch: master
Review: https://review.openstack.org/77562

Changed in horizon:
status:	New → In Progress

Akihiro Motoki (amotoki) on 2014-03-03

tags:

added: low-hanging-fruit

Mark Korondi (kmarc) on 2014-03-05

Changed in ceilometer:
assignee:	nobody → Mark Korondi (oro)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-03-06: Fix proposed to ceilometer (master)

#14

Fix proposed to branch: master
Review: https://review.openstack.org/78762

Changed in ceilometer:
status:	New → In Progress

Revision history for this message

Ildiko Vancsa (ildiko-vancsa) wrote on 2014-03-10:

#15

Hi,

This bug has a duplication: https://bugs.launchpad.net/ceilometer/+bug/1277104. There are ongoing activities for both bug reports, some of them are overlapping (Ceilometer and Cinder). It would be good to check these activities and synchronize them.

Best Regards,
Ildiko

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-03-24: Fix proposed to python-heatclient (master)

#16

Fix proposed to branch: master
Review: https://review.openstack.org/82498

Revision history for this message

Ildiko Vancsa (ildiko-vancsa) wrote on 2014-04-02:

#17

Patch for python-ceilometerclient: https://review.openstack.org/#/c/81154/3

Changed in python-ceilometerclient:
importance:	Undecided → Low
status:	New → In Progress
assignee:	nobody → Jia Dong (jiadong-jia)

Steve Baker (steve-stevebaker) on 2014-04-07

Changed in python-heatclient:
milestone:	v0.2.9 → none

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-04-15: Fix merged to python-heatclient (master)

#18

Reviewed: https://review.openstack.org/82498
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=e07e9d936665d4c7e58edc30e2746544ce4fa784
Submitter: Jenkins
Branch: master

commit e07e9d936665d4c7e58edc30e2746544ce4fa784
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Mar 24 14:58:47 2014 +0200

Use correct order of arguments to assertEqual

The correct order of arguments to assertEqual that is expected by
testtools is (expected, observed).

This patch fixes the inverted usage of arguments in some places
that have cropped up since the last fix of this bug.

Change-Id: Ifbc5da5cba0c8dcdf5b9c9eb6e6bfb1b1c2b49b0
Closes-Bug: #1259292

Changed in python-heatclient:
status:	In Progress → Fix Committed

Revision history for this message

Sandeep Kedari (sandy86299) wrote on 2014-05-21:

#19

Working on the following bug

Changed in cinder:
assignee:	Kiyohiro Adachi (adachi) → Sandeep Kedari (sandy86299)

John Griffith (john-griffith) on 2014-06-13

Changed in cinder:
importance:	Low → Wishlist

Revision history for this message

gordon chung (chungg) wrote on 2014-06-16:

#20

marking invalid for ceilometer, will track via https://bugs.launchpad.net/ceilometer/+bug/1277104

Changed in ceilometer:
status:	In Progress → Invalid

David Lyle (david-lyle) on 2014-06-24

Changed in horizon:
importance:	Undecided → Wishlist

Steve Baker (steve-stevebaker) on 2014-06-26

Changed in python-heatclient:
milestone:	none → v0.2.10

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-12: Change abandoned on cinder (master)

#21

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/75357
Reason: Abandoning change: No update for more than 14 days

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-28: Fix merged to python-cinderclient (master)

#22

Reviewed: https://review.openstack.org/76453
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=f3ec0814971112068e933e343ef7ab8986f438c3
Submitter: Jenkins
Branch: master

commit f3ec0814971112068e933e343ef7ab8986f438c3
Author: KIYOHIRO ADACHI <email address hidden>
Date: Wed Feb 26 15:59:14 2014 +0900

Fix order of arguments in assertEqual

Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is...

def assertEqual(self, expected, observed, message=''):
"""Assert that 'expected' is equal to 'observed'.

            :param expected: The expected value.
            :param observed: The observed value.
            :param message: An optional message to include in the error.
            """

    The string length of the sum of the results of repr(expected) and
    repr(observed) is greater than 70, then, MismatchError message is
    changed, as below.

      Ex.:
            raise mismatch_error
        MismatchError: !=:
        reference = '_123456789_123456789_bar'
        actual = '_123456789_123456789_123456789_123456789_123456789'

Change-Id: Id02ddfb2ca03df7f432cff67a7bed182cccc4924
Closes-Bug: #1259292

Changed in python-cinderclient:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-09-04: Fix merged to horizon (master)

#23

Reviewed: https://review.openstack.org/77562
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c7d5371b47079a07f32137e82422ded41d501a9f
Submitter: Jenkins
Branch: master

commit c7d5371b47079a07f32137e82422ded41d501a9f
Author: ChenZheng <email address hidden>
Date: Mon Mar 3 18:48:46 2014 +0800

Fix order of arguments in assertEqual

Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is
assertEqual(expected, observed).

Change-Id: Iabf6e55146412b57b6a6544f312f9510f762566a
Partial-Bug: #1259292

Steve Baker (steve-stevebaker) on 2014-09-18

no longer affects:

python-heatclient

Revision history for this message

Qiming Teng (tengqim) wrote on 2014-12-02:

#24

Qiming is screening the heat code base to make sure Heat is not affected by this.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-12-02: Fix proposed to heat (master)

#25

Fix proposed to branch: master
Review: https://review.openstack.org/138369

Changed in heat:
assignee:	Pavlo Shchelokovskyy (pshchelo) → Qiming Teng (tengqim)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-12-03: Fix merged to heat (master)

#26

Reviewed: https://review.openstack.org/138369
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3d2b7facdab23181b876b2272f587a2400caadc1
Submitter: Jenkins
Branch: master

commit 3d2b7facdab23181b876b2272f587a2400caadc1
Author: tengqm <email address hidden>
Date: Tue Dec 2 21:44:12 2014 +0800

Make all assertEqual() calls conform to convention

    It is a convention to have assertEqual() assertions invoked with
    'expected value' before 'actual value', or else the debug output may
    become very confusing. This patch fixes about 100 violations in current
    test cases where about 3580 assertEqual calls are made.

Closes-Bug: 1259292
Change-Id: I2e0474d9821716baf35a3bbb2952c63a84749dd3

Changed in heat:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-12-18

Changed in heat:
milestone:	none → kilo-1
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-06: Fix proposed to cinder (master)

#27

Fix proposed to branch: master
Review: https://review.openstack.org/145118

Changed in cinder:
assignee:	Sandeep Kedari (sandy86299) → Accela Zhao (accelazh)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-06:

#28

Fix proposed to branch: master
Review: https://review.openstack.org/145133

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-06:

#29

Fix proposed to branch: master
Review: https://review.openstack.org/145162

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-06:

#30

Fix proposed to branch: master
Review: https://review.openstack.org/145166

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-06:

#31

Fix proposed to branch: master
Review: https://review.openstack.org/145173

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-07: Fix merged to cinder (master)

#32

Reviewed: https://review.openstack.org/145133
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f743605fa3dae8f57003e50fa50c864a89e8c3b2
Submitter: Jenkins
Branch: master

commit f743605fa3dae8f57003e50fa50c864a89e8c3b2
Author: Bharat Kumar Kobagana <email address hidden>
Date: Tue Jan 6 11:14:18 2015 +0530

Fix argument order in assertEqual: tests/test_glusterfs.py

    The assertEqual in cinder/tests/test_glusterfs.py is using
    incorrect argument order (observed, expected), which causes the
    error message about mismatch to be reversed if the test case fails.
    Change it to (expected, observed).

Change-Id: Idcd88de9c5e8a096f0ef473e92bff17e6be16814
Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-05: Change abandoned on cinder (master)

#33

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/145162
Reason: inactive for a month

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-06: Fix merged to cinder (master)

#34

Reviewed: https://review.openstack.org/145166
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d813f3f005be6043e615c57f3f7b0a3e0b4d30b3
Submitter: Jenkins
Branch: master

commit d813f3f005be6043e615c57f3f7b0a3e0b4d30b3
Author: Bharat Kumar Kobagana <email address hidden>
Date: Tue Jan 6 14:08:05 2015 +0530

Fix argument order in assertEqual: tests/test_nfs.py

    The assertEqual in cinder/tests/test_nfs.py is using
    incorrect argument order (observed, expected), which causes the
    error message about mismatch to be reversed if the test case fails.
    Change it to (expected, observed).

Change-Id: I7fec2e5df91369c3cae2adef3189e8bd86fe4480
Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-08: Change abandoned on cinder (master)

#35

Change abandoned by Bharat Kumar Kobagana (<email address hidden>) on branch: master
Review: https://review.openstack.org/145173
Reason: As this patch is not necessary as a separate patch.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-19: Fix proposed to cinder (master)

#36

Fix proposed to branch: master
Review: https://review.openstack.org/157474

Changed in cinder:
assignee:	Accela Zhao (accelazh) → Sai Kiran (saikiran)

Vitalii Gridnev (vgridnev) on 2015-02-26

Changed in sahara:
status:	New → Confirmed

Jacob Bin Wang (dongliang0531) on 2015-03-18

Changed in sahara:
assignee:	nobody → Jacob Bin Wang (dongliang0531)

Jacob Bin Wang (dongliang0531) on 2015-03-18

Changed in sahara:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-18: Fix proposed to sahara (master)

#37

Fix proposed to branch: master
Review: https://review.openstack.org/165271

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-18:

#38

Fix proposed to branch: master
Review: https://review.openstack.org/165347

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-18:

#39

Fix proposed to branch: master
Review: https://review.openstack.org/165350

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-23: Fix merged to sahara (master)

#40

Reviewed: https://review.openstack.org/165271
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=cb480679a1f75f558be414f85143c11b2406a31b
Submitter: Jenkins
Branch: master

commit cb480679a1f75f558be414f85143c11b2406a31b
Author: Jacob Bin Wang <email address hidden>
Date: Wed Mar 18 09:29:40 2015 +0800

Fix order of arguments in assertEqual - Part1

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is:
        def assertEqual(self, expected, observed, message='')
    Changed to use the right order. Also if the order is wrong and
    expected value is None, change it to assertIsNone instead.

    It requires big changes and some tests change frequently.
    So I would do it in series of small CR.
    This part contains all changes except tests of plugins and service.

Partial-Bug: #1259292

Change-Id: Iefbb5f4b9efca35f7a2298f9f7f5b9de73fc260f

OpenStack Infra (hudson-openstack) on 2015-03-23

Changed in sahara:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2015-04-09

Changed in sahara:
milestone:	none → kilo-rc1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-04-30

Changed in sahara:
milestone:	kilo-rc1 → 2015.1.0

Thierry Carrez (ttx) on 2015-04-30

Changed in heat:
milestone:	kilo-1 → 2015.1.0

Doug Hellmann (doug-hellmann) on 2015-07-08

Changed in python-cinderclient:
milestone:	none → 1.3.1
status:	Fix Committed → Fix Released

Apoorva Deshpande (apoorvad) on 2015-07-26

Changed in cinder:
assignee:	Sai Kiran (saikiran) → Apoorva Deshpande (apoorvad)

Yusuke Hayashi (hayashi-yusuke) on 2015-08-05

Changed in manila:
assignee:	nobody → Yusuke Hayashi (hayashi-yusuke)

OpenStack Infra (hudson-openstack) on 2015-08-06

Changed in cinder:
assignee:	Apoorva Deshpande (apoorvad) → Skyler Berg (sberg-l)

OpenStack Infra (hudson-openstack) on 2015-08-11

Changed in cinder:
status:	In Progress → Fix Committed

OpenStack Infra (hudson-openstack) on 2015-08-15

Changed in manila:
status:	New → In Progress

chenying (ying-chen) on 2015-08-20

Changed in cinder:
status:	Fix Committed → Confirmed

chenying (ying-chen) on 2015-08-20

Changed in cinder:
status:	Confirmed → Fix Committed

Pranali Deore (pranali-deore) on 2015-08-31

Changed in nova:
assignee:	nobody → Pranali Deore (pranali-deore)

OpenStack Infra (hudson-openstack) on 2015-08-31

Changed in nova:
status:	New → In Progress

Valeriy Ponomaryov (vponomaryov) on 2015-09-01

Changed in manila:
importance:	Undecided → Low

Sergey Nikitin (snikitin) on 2015-09-02

Changed in nova:
importance:	Undecided → Wishlist

OpenStack Infra (hudson-openstack) on 2015-09-03

Changed in nova:
assignee:	Pranali Deore (pranali-deore) → Rajesh Tailor (rajesh-tailor)
assignee:	Rajesh Tailor (rajesh-tailor) → Pranali Deore (pranali-deore)

OpenStack Infra (hudson-openstack) on 2015-09-03

Changed in nova:
assignee:	Pranali Deore (pranali-deore) → Rajesh Tailor (rajesh-tailor)

Thierry Carrez (ttx) on 2015-09-03

Changed in cinder:
milestone:	none → liberty-3
status:	Fix Committed → Fix Released

OpenStack Infra (hudson-openstack) on 2015-09-07

Changed in nova:
assignee:	Rajesh Tailor (rajesh-tailor) → Pranali Deore (pranali-deore)

OpenStack Infra (hudson-openstack) on 2015-09-08

Changed in nova:
assignee:	Pranali Deore (pranali-deore) → Rajesh Tailor (rajesh-tailor)

Rajesh Tailor (rajesh-tailor) on 2015-09-10

Changed in glance:
assignee:	nobody → Rajesh Tailor (rajesh-tailor)

Rajesh Tailor (rajesh-tailor) on 2015-09-10

Changed in keystone:
assignee:	nobody → Rajesh Tailor (rajesh-tailor)
Changed in neutron:
assignee:	nobody → Rajesh Tailor (rajesh-tailor)

Dolph Mathews (dolph) on 2015-09-10

Changed in keystone:
importance:	Undecided → Low
status:	New → Triaged

gordon chung (chungg) on 2015-09-11

Changed in python-ceilometerclient:
assignee:	Jia Dong (jiadong-jia) → nobody
status:	In Progress → Invalid

OpenStack Infra (hudson-openstack) on 2015-09-14

Changed in glance:
status:	New → In Progress

Assaf Muller (amuller) on 2015-09-22

no longer affects:

neutron

OpenStack Infra (hudson-openstack) on 2015-09-23

Changed in keystone:
status:	Triaged → In Progress

Ekaterina Chernova (efedorova) on 2015-09-24

Changed in murano:
assignee:	nobody → Tetiana Lashchova (tlashchova)
importance:	Undecided → Medium
milestone:	none → liberty-rc1
status:	New → Confirmed

Ekaterina Chernova (efedorova) on 2015-09-24

Changed in murano:
milestone:	liberty-rc1 → liberty-rc2

Serg Melikyan (smelikyan) on 2015-09-24

Changed in murano:
milestone:	liberty-rc2 → mitaka-1

Md Nadeem (mail2nadeem92) on 2015-09-28

Changed in zaqar:
assignee:	nobody → MD NADEEM (mail2nadeem92)
Changed in python-zaqarclient:
assignee:	nobody → MD NADEEM (mail2nadeem92)

Hardik Parekh (hardik-parekh047) on 2015-09-28

Changed in mistral:
assignee:	nobody → hardik (hardik-parekh047)

OpenStack Infra (hudson-openstack) on 2015-09-28

Changed in mistral:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-09-28

Changed in zaqar:
status:	New → In Progress
Changed in glance:
status:	In Progress → Fix Committed

OpenStack Infra (hudson-openstack) on 2015-09-28

Changed in python-zaqarclient:
status:	New → In Progress

Nikolay Makhotkin (nmakhotkin) on 2015-09-28

Changed in mistral:
importance:	Undecided → Medium
milestone:	none → liberty-rc2
importance:	Medium → Low

Hardik Parekh (hardik-parekh047) on 2015-09-28

Changed in python-mistralclient:
assignee:	nobody → hardik (hardik-parekh047)

sonu (sonu-bhumca11) on 2015-09-29

Changed in designate:
status:	New → Confirmed
assignee:	nobody → sonu (sonu-bhumca11)
status:	Confirmed → New
status:	New → Confirmed
status:	Confirmed → New

Anusha (anusha-iiitm) on 2015-09-29

Changed in congress:
assignee:	nobody → Anusha (anusha-iiitm)

sonu (sonu-bhumca11) on 2015-09-29

Changed in python-designateclient:
assignee:	nobody → sonu (sonu-bhumca11)

OpenStack Infra (hudson-openstack) on 2015-09-29

Changed in congress:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-09-29

Changed in designate:
status:	New → In Progress

Pradeep Kumar Singh (pradeep-singh-u) on 2015-09-29

Changed in barbican:
assignee:	nobody → Pradeep Kumar Singh (pradeep-singh-u)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-09-29

Changed in python-designateclient:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-09-29

Changed in murano:
status:	Confirmed → In Progress

Kirill Zaitsev (kzaitsev) on 2015-09-29

Changed in murano:
importance:	Medium → Low

OpenStack Infra (hudson-openstack) on 2015-09-29

Changed in murano:
status:	In Progress → Fix Committed

David Stanek (dstanek) on 2015-09-30

Changed in keystone:
assignee:	Rajesh Tailor (rajesh-tailor) → nobody
status:	In Progress → Fix Committed

Hardik Parekh (hardik-parekh047) on 2015-10-01

Changed in python-mistralclient:
status:	New → In Progress

John Garbutt (johngarbutt) on 2015-10-05

Changed in nova:
assignee:	Rajesh Tailor (rajesh-tailor) → nobody
status:	In Progress → Won't Fix

lei zhang (zhang-lei) on 2015-10-09

Changed in magnum:
assignee:	nobody → lei zhang (zhang-lei)

Yusuke Hayashi (hayashi-yusuke) on 2015-10-09

Changed in manila:
status:	In Progress → Fix Committed

Md Nadeem (mail2nadeem92) on 2015-10-09

Changed in zaqar:
status:	In Progress → Fix Committed

OpenStack Infra (hudson-openstack) on 2015-10-10

Changed in magnum:
status:	New → In Progress

Md Nadeem (mail2nadeem92) on 2015-10-13

Changed in python-zaqarclient:
status:	In Progress → Fix Committed

lei zhang (zhang-lei) on 2015-10-13

Changed in magnum:
status:	In Progress → Fix Committed

OpenStack Infra (hudson-openstack) on 2015-10-13

tags:

added: in-stable-liberty

Renat Akhmerov (rakhmerov) on 2015-10-13

Changed in mistral:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2015-10-15

Changed in cinder:
milestone:	liberty-3 → 7.0.0

Hardik Parekh (hardik-parekh047) on 2015-10-16

Changed in mistral:
status:	Fix Committed → Fix Released

Renat Akhmerov (rakhmerov) on 2015-10-16

Changed in mistral:
milestone:	liberty-rc2 → liberty

Nikolay Makhotkin (nmakhotkin) on 2015-10-16

Changed in python-mistralclient:
status:	In Progress → Fix Released

Michal Dulko (michal-dulko-f) on 2015-10-22

Changed in cinder:
assignee:	Skyler Berg (sberg-l) → nobody
milestone:	7.0.0 → none
status:	Fix Released → Confirmed

Nate Potter (ntpttr) on 2015-10-22

Changed in cinder:
assignee:	nobody → Nate Potter (ntpttr)
status:	Confirmed → In Progress

OpenStack Infra (hudson-openstack) on 2015-11-13

Changed in cinder:
status:	In Progress → Fix Committed

Davanum Srinivas (DIMS) (dims-v) on 2015-11-17

Changed in python-zaqarclient:
milestone:	none → 0.3.0
status:	Fix Committed → Fix Released

Adrian Otto (aotto) on 2015-11-24

Changed in magnum:
milestone:	none → mitaka-1
status:	Fix Committed → Fix Released

Steve Martinelli (stevemar) on 2015-12-01

Changed in keystone:
milestone:	none → mitaka-1

Doug Hellmann (doug-hellmann) on 2015-12-02

Changed in glance:
status:	Fix Committed → Fix Released

sonu (sonu-bhumca11) on 2015-12-03

Changed in designate:
status:	In Progress → Fix Committed
Changed in python-designateclient:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2015-12-03

Changed in cinder:
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2015-12-03

Changed in manila:
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2015-12-03

Changed in designate:
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2015-12-03

Changed in keystone:
status:	Fix Committed → Fix Released

Kirill Zaitsev (kzaitsev) on 2015-12-03

Changed in murano:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-12-04

Changed in zaqar:
status:	Fix Committed → Fix Released

Reedip (reedip-banerjee-deactivatedaccount) on 2016-01-12

Changed in python-solumclient:
assignee:	nobody → Reedip (reedip-banerjee)

OpenStack Infra (hudson-openstack) on 2016-01-19

Changed in python-solumclient:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-20

Changed in python-solumclient:
status:	In Progress → Fix Released

Anusha (anusha-iiitm) on 2016-03-10

Changed in congress:
status:	In Progress → Fix Committed

Tim Hinrichs (thinrichs) on 2016-04-13

Changed in congress:
milestone:	none → mitaka
status:	Fix Committed → Fix Released

Fernando Diaz (diazjf) on 2016-05-10

Changed in barbican:
importance:	Undecided → Wishlist

Yafei Yu (yu-yafei) on 2016-06-15

Changed in os-brick:
assignee:	nobody → yuyafei (yu-yafei)

Vstorage_ZTE (zheng-yao1) on 2016-06-15

Changed in python-glanceclient:
assignee:	nobody → YaoZheng_ZTE (zheng-yao1)

OpenStack Infra (hudson-openstack) on 2016-06-15

Changed in os-brick:
status:	New → In Progress

Yafei Yu (yu-yafei) on 2016-06-15

Changed in glance-store:
assignee:	nobody → yuyafei (yu-yafei)

OpenStack Infra (hudson-openstack) on 2016-06-15

Changed in glance-store:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-06-15

Changed in python-glanceclient:
status:	New → In Progress

Vstorage_ZTE (zheng-yao1) on 2016-06-15

Changed in glance-store:
importance:	Undecided → Low

Eric Harney (eharney) on 2016-06-15

Changed in os-brick:
importance:	Undecided → Wishlist

jingtao liang (liang-jingtao) on 2016-06-21

Changed in nova:
assignee:	nobody → jingtao liang (liang-jingtao)
assignee:	jingtao liang (liang-jingtao) → nobody
Changed in keystone:
assignee:	nobody → jingtao liang (liang-jingtao)

OpenStack Infra (hudson-openstack) on 2016-06-21

Changed in glance-store:
status:	In Progress → Fix Released

Thomas Herve (therve) on 2016-06-22

no longer affects:

heat

Ji.Wei (jiwei) on 2016-06-22

Changed in tempest:
assignee:	nobody → Ji.Wei (jiwei)

Ji.Wei (jiwei) on 2016-06-22

Changed in sqlalchemy-migrate:
assignee:	nobody → Ji.Wei (jiwei)

Ji.Wei (jiwei) on 2016-06-22

Changed in freezer:
assignee:	nobody → Ji.Wei (jiwei)

Samuel de Medeiros Queiroz (samueldmq) on 2016-06-22

Changed in keystone:
importance:	Low → Wishlist

Ji.Wei (jiwei) on 2016-06-23

Changed in blazar:
assignee:	nobody → Ji.Wei (jiwei)

Ji.Wei (jiwei) on 2016-06-23

Changed in astara:
assignee:	nobody → Ji.Wei (jiwei)
Changed in tacker:
assignee:	nobody → Ji.Wei (jiwei)

OpenStack Infra (hudson-openstack) on 2016-06-23

Changed in astara:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-06-23

Changed in freezer:
status:	New → In Progress

jingtao liang (liang-jingtao) on 2016-06-24

Changed in swift-swf:
assignee:	nobody → jingtao liang (liang-jingtao)

Ji.Wei (jiwei) on 2016-06-24

Changed in higgins:
assignee:	nobody → Ji.Wei (jiwei)

Ji.Wei (jiwei) on 2016-06-29

Changed in daisycloud-core:
assignee:	nobody → Ji.Wei (jiwei)

OpenStack Infra (hudson-openstack) on 2016-06-29

Changed in python-glanceclient:
status:	In Progress → Fix Released

Yan Songming (songmingyan) on 2016-07-02

Changed in neutron:
assignee:	nobody → Yan Songming (songmingyan)
Changed in python-neutronclient:
assignee:	nobody → Yan Songming (songmingyan)
no longer affects:	neutron

Yan Songming (songmingyan) on 2016-07-02

Changed in networking-sfc:
assignee:	nobody → Yan Songming (songmingyan)

Yan Songming (songmingyan) on 2016-07-02

no longer affects:

python-neutronclient

OpenStack Infra (hudson-openstack) on 2016-07-04

Changed in networking-sfc:
status:	New → In Progress

qinchunhua (qin-chunhua) on 2016-07-05

Changed in tacker:
assignee:	Ji.Wei (jiwei) → qinchunhua (qin-chunhua)
status:	New → In Progress

Ji.Wei (jiwei) on 2016-07-05

Changed in astara:
status:	In Progress → Fix Released

hongzhezheng (zheng-hongzhe32) on 2016-07-06

Changed in networking-infoblox:
assignee:	nobody → hongzhezheng (zheng-hongzhe32)
Changed in python-barbicanclient:
assignee:	nobody → hongzhezheng (zheng-hongzhe32)

Yafei Yu (yu-yafei) on 2016-07-06

Changed in solum:
assignee:	nobody → yuyafei (yu-yafei)

OpenStack Infra (hudson-openstack) on 2016-07-06

Changed in solum:
status:	New → In Progress

hongzhezheng (zheng-hongzhe32) on 2016-07-06

Changed in rally:
assignee:	nobody → hongzhezheng (zheng-hongzhe32)

Pierre-Arthur MATHIEU (pi3rra) on 2016-07-06

Changed in freezer:
importance:	Undecided → Low

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in networking-infoblox:
status:	New → In Progress

qinchunhua (qin-chunhua) on 2016-07-07

Changed in networking-l2gw:
assignee:	nobody → qinchunhua (qin-chunhua)

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in networking-l2gw:
status:	New → In Progress

Yan Songming (songmingyan) on 2016-07-07

Changed in networking-calico:
assignee:	nobody → Yan Songming (songmingyan)

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in python-barbicanclient:
status:	New → In Progress

weiweigu (gu-weiwei) on 2016-07-07

Changed in pbr:
assignee:	nobody → weiweigu (gu-weiwei)

jingtao liang (liang-jingtao) on 2016-07-07

Changed in pycadf:
assignee:	nobody → jingtao liang (liang-jingtao)

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in tempest:
assignee:	Ji.Wei (jiwei) → Anthony Washington (anthony-washington)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in tacker:
assignee:	qinchunhua (qin-chunhua) → Kanagaraj Manickam (kanagaraj-manickam)

OpenStack Infra (hudson-openstack) on 2016-07-07

Changed in networking-sfc:
status:	In Progress → Fix Released

Anthony Washington (anthony-washington) on 2016-07-07

Changed in tempest:
status:	In Progress → Invalid

OpenStack Infra (hudson-openstack) on 2016-07-08

Changed in solum:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-07-11

Changed in tacker:
assignee:	Kanagaraj Manickam (kanagaraj-manickam) → JianGang Weng (weng-jiangang)

OpenStack Infra (hudson-openstack) on 2016-07-11

Changed in tacker:
assignee:	JianGang Weng (weng-jiangang) → qinchunhua (qin-chunhua)

OpenStack Infra (hudson-openstack) on 2016-07-12

Changed in tacker:
assignee:	qinchunhua (qin-chunhua) → JianGang Weng (weng-jiangang)

OpenStack Infra (hudson-openstack) on 2016-07-12

Changed in pbr:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-07-12

Changed in tacker:
assignee:	JianGang Weng (weng-jiangang) → qinchunhua (qin-chunhua)

OpenStack Infra (hudson-openstack) on 2016-07-12

Changed in os-brick:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-07-13

Changed in pbr:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-07-13

Changed in tacker:
assignee:	qinchunhua (qin-chunhua) → JianGang Weng (weng-jiangang)

Roman Vasilets (rvasilets) on 2016-07-15

Changed in rally:
importance:	Undecided → Low

Anthony Washington (anthony-washington) on 2016-07-20

Changed in tempest:
assignee:	Anthony Washington (anthony-washington) → nobody

OpenStack Infra (hudson-openstack) on 2016-08-16

Changed in horizon:
assignee:	ChenZheng (chen-zheng) → Tuan (tuanla)

Sharat Sharma (sharat-sharma) on 2016-08-17

Changed in rally:
assignee:	hongzhezheng (zheng-hongzhe32) → Sharat Sharma (sharat-sharma)
status:	New → In Progress

Jeremy Liu (liujiong) on 2016-08-18

Changed in bandit:
assignee:	nobody → Jiong Liu (liujiong)

OpenStack Infra (hudson-openstack) on 2016-08-18

Changed in bandit:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-08-22

Changed in networking-calico:
status:	New → In Progress

218 comments hidden

view all 298 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-01: Fix included in openstack/solum 5.0.0

#259

This issue was fixed in the openstack/solum 5.0.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-01: Fix included in openstack/python-cinderclient 1.9.0

#260

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-06: Fix included in openstack/networking-sfc 2.0.0

#261

This issue was fixed in the openstack/networking-sfc 2.0.0 release.

1 comments hidden

view all 298 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-08: Fix proposed to networking-infoblox (stable/liberty)

#263

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/367442

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-09: Fix included in openstack/networking-sfc 2.0.0

#264

This issue was fixed in the openstack/networking-sfc 2.0.0 release.

1 comments hidden

view all 298 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-12: Fix merged to networking-sfc (master)

#266

Reviewed: https://review.openstack.org/361025
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=f7d95a4045c3407063f7906eeb3dda3f4ac1b58c
Submitter: Jenkins
Branch: master

commit f7d95a4045c3407063f7906eeb3dda3f4ac1b58c
Author: SongmingYan <email address hidden>
Date: Fri Aug 26 04:42:38 2016 -0400

Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools
    is assertEqual(expected, observed).

Closes bug: #1259292

Change-Id: If670c54ee7f6dae2911c1165619dcad4dca6c06d

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-15: Change abandoned on barbican (master)

#267

Change abandoned by Tuan Luong-Anh (<email address hidden>) on branch: master
Review: https://review.openstack.org/356283

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-16: Fix merged to networking-calico (master)

#268

Reviewed: https://review.openstack.org/338179
Committed: https://git.openstack.org/cgit/openstack/networking-calico/commit/?id=8599fe0af907bc5aeff29c994bafdf87ef558b71
Submitter: Jenkins
Branch: master

commit 8599fe0af907bc5aeff29c994bafdf87ef558b71
Author: SongmingYan <email address hidden>
Date: Wed Jul 6 06:48:10 2016 -0400

Fix order of arguments in assertEqual

    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is
    assertEqual(expected, observed).

Closes bug: #1259292

Change-Id: I39aa28bea07a3cc6dcab472d526b7d3436d5270d

Changed in networking-calico:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/networking-ovn 1.0.0.0rc1

#269

This issue was fixed in the openstack/networking-ovn 1.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/python-cinderclient 1.9.0

#270

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

Jeremy Liu (liujiong) on 2016-09-29

Changed in barbican:
assignee:	Pradeep Kumar Singh (pradeep-singh-u) → Jeremy Liu (liujiong)
Changed in python-barbicanclient:
assignee:	hongzhezheng (zheng-hongzhe32) → Jeremy Liu (liujiong)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix merged to barbican (master)

#271

Reviewed: https://review.openstack.org/378699
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=403e440f8504d2716b154043565032e3d145b63e
Submitter: Jenkins
Branch: master

commit 403e440f8504d2716b154043565032e3d145b63e
Author: Jiong Liu <email address hidden>
Date: Wed Sep 28 23:19:16 2016 +0800

Fix order of arguments in assertEqual

The correct order expected by testtools is assertEqual(expected, observed).

Change-Id: I93eaab96f170e72cfcbc763f384fd9358842ef69
Partial-Bug: #1259292

Revision history for this message

Steve Martinelli (stevemar) wrote on 2016-10-03:

#272

Fixed in pycadf: https://review.openstack.org/#/c/338781/

Changed in pycadf:
importance:	Undecided → Low
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-14: Fix merged to python-barbicanclient (master)

#273

Reviewed: https://review.openstack.org/338717
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=86d91e4e4e39ed0b4b65e393ca49172fd555ddd0
Submitter: Jenkins
Branch: master

commit 86d91e4e4e39ed0b4b65e393ca49172fd555ddd0
Author: hongzhezheng <email address hidden>
Date: Thu Jul 7 16:23:31 2016 +0800

Fix argument order for assertEqual to (expected, observed)

    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.

Change-Id: I5209e5889cfe62c66dc675c00e3ccaf22410f637
Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-17:

#274

Reviewed: https://review.openstack.org/378684
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=bd97bedb3f9b0bddcf3556acc4cd01ab35c7e960
Submitter: Jenkins
Branch: master

commit bd97bedb3f9b0bddcf3556acc4cd01ab35c7e960
Author: Jiong Liu <email address hidden>
Date: Wed Sep 28 22:59:54 2016 +0800

Fix order of arguments in assertEqual

The correct order expected by testtools is assertEqual(expected, observed).

Change-Id: I8457af6e15a9000dd6c54ad8199331e75bd3c7fd
Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/networking-ovn 1.0.0.0rc1

#275

This issue was fixed in the openstack/networking-ovn 1.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/python-cinderclient 1.9.0

#276

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-31: Fix merged to networking-l2gw (master)

#277

Reviewed: https://review.openstack.org/344085
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=0ded69ae72c8395a1324505e516288801ba369ab
Submitter: Jenkins
Branch: master

commit 0ded69ae72c8395a1324505e516288801ba369ab
Author: LiuYong <email address hidden>
Date: Wed Jul 20 00:05:29 2016 +0800

Remove execute permission which is added by mistake in l2gw

    Some files in networking-l2gw/tests/unit
    were given execute permission by mistake
    in Change-Id: I29020058671348e0734906a71ac3ae0798172a23.
    This proposal want to remove the error permission.

    Change-Id: I7e6466f8e9a0886e293df3f229d03a49b6fc92cc
    Related-Id: I29020058671348e0734906a71ac3ae0798172a23
    Partial-Bug: #1259292

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/python-cloudkittyclient 0.5.0

#278

This issue was fixed in the openstack/python-cloudkittyclient 0.5.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/python-barbicanclient 4.1.0

#279

This issue was fixed in the openstack/python-barbicanclient 4.1.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/python-cinderclient 1.9.0

#280

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-14: Fix included in openstack/networking-sfc 3.0.0

#281

This issue was fixed in the openstack/networking-sfc 3.0.0 release.

1 comments hidden

view all 298 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-07: Fix included in openstack/python-barbicanclient 4.1.0

#283

This issue was fixed in the openstack/python-barbicanclient 4.1.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-07: Fix included in openstack/python-cinderclient 1.9.0

#284

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

Sharat Sharma (sharat-sharma) on 2016-12-23

Changed in rally:
status:	In Progress → New
assignee:	Sharat Sharma (sharat-sharma) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-23: Change abandoned on rally (master)

#285

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/356483

Jeremy Liu (liujiong) on 2017-01-26

Changed in bandit:
status:	In Progress → Fix Committed
Changed in barbican:
status:	In Progress → Fix Committed
Changed in python-barbicanclient:
status:	In Progress → Fix Committed

Nick Miethe (miethe) on 2017-02-16

Changed in swift-swf:
assignee:	jingtao liang (liang-jingtao) → Nick Miethe (miethe)
status:	New → In Progress

Jeremy Liu (liujiong) on 2017-02-26

Changed in python-barbicanclient:
status:	Fix Committed → Fix Released
Changed in bandit:
status:	Fix Committed → Fix Released
Changed in barbican:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-01: Fix included in openstack-dev/pbr 2.0.0

#286

This issue was fixed in the openstack-dev/pbr 2.0.0 release.

sudhir agarwal (sudhir.agarwal) on 2017-03-07

Changed in rally:
assignee:	nobody → sudhir agarwal (sudhir.agarwal)

sudhir agarwal (sudhir.agarwal) on 2017-03-07

Changed in rally:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-09: Fix proposed to rally (master)

#287

Fix proposed to branch: master
Review: https://review.openstack.org/443698

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-11: Change abandoned on rally (master)

#288

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/443698

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-11: Fix proposed to rally (master)

#289

Fix proposed to branch: master
Review: https://review.openstack.org/444582

Anishka Gupta (anishka0107) on 2017-03-26

Changed in sqlalchemy-migrate:
assignee:	Ji.Wei (jiwei) → Anishka Gupta (anishka0107)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-27: Fix proposed to sqlalchemy-migrate (master)

#290

Fix proposed to branch: master
Review: https://review.openstack.org/450148

Changed in sqlalchemy-migrate:
status:	New → In Progress

yong sheng gong (gongysh) on 2017-05-24

Changed in tacker:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-26: Change abandoned on sqlalchemy-migrate (master)

#291

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/450148

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-30: Change abandoned on rally (master)

#292

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/444582

Masahito Muroi (muroi-masahito) on 2017-07-11

Changed in blazar:
importance:	Undecided → Wishlist

sudhir agarwal (sudhir.agarwal) on 2017-07-31

Changed in neutron-quark:
assignee:	nobody → sudhir agarwal (sudhir.agarwal)
status:	New → In Progress
no longer affects:	neutron-quark

sudhir agarwal (sudhir.agarwal) on 2017-08-01

Changed in neutron-quark:
assignee:	nobody → sudhir agarwal (sudhir.agarwal)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-04: Fix merged to rally (master)

#293

Reviewed: https://review.openstack.org/444582
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=0aec3cc166590ea4bc95d4a0dacd7f79dfa84735
Submitter: Jenkins
Branch: master

commit 0aec3cc166590ea4bc95d4a0dacd7f79dfa84735
Author: sudhir_agarwal <email address hidden>
Date: Fri Jun 30 16:43:39 2017 +0530

Fixed order of arguments in assertEqual

    Some tests used incorrect order of arguments in
    assertEqual(observed, expected). The correct order expected
    by testtool is assertEqual(expected, observed).

Partial-Bug: #1259292

Change-Id: I944b72f743a21d0908d17485c25aeb0e7ee70cba

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-11: Change abandoned on quark (master)

#294

Change abandoned by sudhir agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/489232

Hiroaki Kobayashi (hiro-kobayashi) on 2017-08-31

Changed in blazar:
status:	New → Triaged

qinchunhua (qin-chunhua) on 2017-09-12

Changed in networking-l2gw:
assignee:	qinchunhua (qin-chunhua) → nobody
assignee:	nobody → qinchunhua (qin-chunhua)
status:	In Progress → Fix Committed

Ricardo Noriega (rnoriega-b) on 2017-09-12

Changed in networking-l2gw:
status:	Fix Committed → Fix Released

Ivan Kolodyazhny (e0ne) on 2017-09-20

Changed in horizon:
status:	In Progress → Fix Released

Akihiro Motoki (amotoki) on 2017-10-24

Changed in horizon:
milestone:	none → queens-1

Nguyen Hai (nguyentrihai93-deactivatedaccount) on 2018-02-20

Changed in tacker:
status:	Fix Committed → Fix Released

Ji.Wei (jiwei) on 2018-03-05

Changed in blazar:
assignee:	Ji.Wei (jiwei) → nobody
Changed in higgins:
assignee:	Ji.Wei (jiwei) → nobody
Changed in freezer:
assignee:	Ji.Wei (jiwei) → nobody
Changed in daisycloud-core:
assignee:	Ji.Wei (jiwei) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-26: Fix proposed to freezer-api (master)

#295

Fix proposed to branch: master
Review: https://review.openstack.org/564482

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-11: Fix merged to freezer-api (master)

#296

Reviewed: https://review.openstack.org/564482
Committed: https://git.openstack.org/cgit/openstack/freezer-api/commit/?id=67e5953c1c66a27dea021abb86029b2470114fb4
Submitter: Zuul
Branch: master

commit 67e5953c1c66a27dea021abb86029b2470114fb4
Author: Oleksiy Petrenko <email address hidden>
Date: Thu Apr 26 15:29:57 2018 +0300

Rework AseertEqual params order in freezer-api
from (got, expected) to (expected, got)

Change-Id: Id4ec8f561ce707fbbb60ae49bf5ad95d22ecd223
Close-Bug: #1259292

sudhir agarwal (sudhir.agarwal) on 2018-05-14

Changed in rally:
assignee:	sudhir agarwal (sudhir.agarwal) → nobody
status:	In Progress → New
assignee:	nobody → sudhir agarwal (sudhir.agarwal)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-12: Fix merged to blazar (master)

#297

Reviewed: https://review.openstack.org/485050
Committed: https://git.openstack.org/cgit/openstack/blazar/commit/?id=3fdac0da7dc2ca752b9dd9de854c16e1d8debf1b
Submitter: Zuul
Branch: master

commit 3fdac0da7dc2ca752b9dd9de854c16e1d8debf1b
Author: Kiran_totad <email address hidden>
Date: Wed Jul 19 11:33:48 2017 +0530

Fix order of arguments in assertEqual

Some tests incorrectly used the order assertEqual(observed, expected).

The correct order expected by testtools is
assertEqual(expected, observed).

Change-Id: Idbb127147df5acc03287b6a7c1f8d24a37fd663e
Closes-Bug: #1259292

Changed in blazar:
status:	Triaged → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-21: Fix included in openstack/blazar 3.0.0.0rc1

#298

This issue was fixed in the openstack/blazar 3.0.0.0rc1 release candidate.

Michael Johnson (johnsom) on 2022-05-03

Changed in python-designateclient:
status:	Fix Committed → Fix Released

Displaying first 40 and last 40 comments. View all 298 comments or add a comment.

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

You are

Subscribing...

Edit bug mail

Other bug subscribers

Related blueprints

Common standard for assertEqual usage in neutron unit testing

Remote bug watches

Bug watches keep track of this bug in other bug trackers.