Neutron FWaaS dashboard

Incorrect success message of remove routers with firewall in Horizon

Bug #1513396 reported by Bao Fangyan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Neutron FWaaS dashboard
Confirmed
Low
Unassigned

Bug Description

Steps to reproduce:
1) Create allow icmp rule
2) Create policy with this rule
3) Create firewall with the policy and associate router1 in Horizon
4) Click remove router,do nothing or unselect router1 then select it again.

Result:
There's a success message says:"Router(s) was successfully removed from firewall fw."

In fact,the unselected router will be remove.

Tags: v1-dashboard
Pallavi (p-pallavi)
Changed in horizon:
assignee: nobody → Pallavi (p-pallavi)
Revision history for this message
Pallavi (p-pallavi) wrote :

Hi,

     I have reproduced the bug as provided in the bug description and could see the success message ""Router(s) was successfully removed from firewall fw." eventhough no routers were removed. Ideally, we should unselect the router we want to remove(by default all the routers will be selected).

     I have modified the code such that instead of the success message, the below failure message will be printed if we do nothing or unselect the router and select it again.

    "Error: Failed to remove router(s) from firewall FW: as none of the routers were unselected"

     Please provide your comments.

Thanks & Regards,
Pallavi.

Revision history for this message
Matthias Runge (mrunge) wrote :

you already assigned the bug to you, just go ahead and fix it.

Revision history for this message
Yi Zhao (zhaoyi44-s) wrote :

@Pallavi, looks good to me, just go ahead

David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
status: New → Confirmed
surbhi sarda (surbhisarda)
Changed in horizon:
assignee: Pallavi (p-pallavi) → surbhi sarda (surbhisarda)
Revision history for this message
surbhi sarda (surbhisarda) wrote :

according to the bug does it mean that only selected router must be removed and not the unselected router. Because in mitaka its mentioned that it will delete all the unselected routers but not the selected routers.

surbhi sarda (surbhisarda)
Changed in horizon:
assignee: surbhi sarda (surbhisarda) → nobody
Akihiro Motoki (amotoki)
affects: horizon → neutron-fwaas-dashboard
Revision history for this message
Akihiro Motoki (amotoki) wrote :

This bug still exists in Pike neutron-fwaas-dashboard.

Akihiro Motoki (amotoki)
tags: added: v1-dashboard
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.