networking-midonet

python3 unit tests jobs are failing on master branch

Bug #1871568 reported by Slawek Kaplonski
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
Critical
Slawek Kaplonski

Bug Description

Example of failure:

https://597ef7c31692766b550c-101ba07b6533bbcf6d7f093fe971b8ef.ssl.cf2.rackcdn.com/700311/3/check/openstack-tox-py36/e324b60/testr_results.html

failure logs:

2020-04-07 09:27:35.620320 | ubuntu-bionic | ==============================
2020-04-07 09:27:35.620343 | ubuntu-bionic | Failed 2 tests - output below:
2020-04-07 09:27:35.620365 | ubuntu-bionic | ==============================
2020-04-07 09:27:35.620444 | ubuntu-bionic |
2020-04-07 09:27:35.620492 | ubuntu-bionic | midonet.neutron.tests.unit.agent.test_interface.TestMidonetInterfaceDriver.test_plug
2020-04-07 09:27:35.620570 | ubuntu-bionic | ------------------------------------------------------------------------------------
2020-04-07 09:27:35.620595 | ubuntu-bionic |
2020-04-07 09:27:35.620618 | ubuntu-bionic | Captured traceback:
2020-04-07 09:27:35.620645 | ubuntu-bionic | ~~~~~~~~~~~~~~~~~~~
2020-04-07 09:27:35.620669 | ubuntu-bionic | Traceback (most recent call last):
2020-04-07 09:27:35.620693 | ubuntu-bionic |
2020-04-07 09:27:35.620717 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/.tox/py36/lib/python3.6/site-packages/neutron/tests/base.py", line 182, in func
2020-04-07 09:27:35.620742 | ubuntu-bionic | return f(self, *args, **kwargs)
2020-04-07 09:27:35.620764 | ubuntu-bionic |
2020-04-07 09:27:35.620789 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/midonet/neutron/tests/unit/agent/test_interface.py", line 50, in test_plug
2020-04-07 09:27:35.620813 | ubuntu-bionic | self.bridge, self.namespace)
2020-04-07 09:27:35.620836 | ubuntu-bionic |
2020-04-07 09:27:35.620860 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/.tox/py36/lib/python3.6/site-packages/neutron/agent/linux/interface.py", line 268, in plug
2020-04-07 09:27:35.620884 | ubuntu-bionic | bridge, namespace, prefix, mtu, link_up)
2020-04-07 09:27:35.620924 | ubuntu-bionic |
2020-04-07 09:27:35.620951 | ubuntu-bionic | TypeError: plug_new() takes from 5 to 9 positional arguments but 10 were given
2020-04-07 09:27:35.620974 | ubuntu-bionic |
2020-04-07 09:27:35.620997 | ubuntu-bionic |
2020-04-07 09:27:35.621022 | ubuntu-bionic | midonet.neutron.tests.unit.db.test_migrations.TestModelsMigrationsMysql.test_models_sync
2020-04-07 09:27:35.621044 | ubuntu-bionic | ----------------------------------------------------------------------------------------
2020-04-07 09:27:35.621083 | ubuntu-bionic |
2020-04-07 09:27:35.621107 | ubuntu-bionic | Captured traceback:
2020-04-07 09:27:35.621142 | ubuntu-bionic | ~~~~~~~~~~~~~~~~~~~
2020-04-07 09:27:35.621164 | ubuntu-bionic | Traceback (most recent call last):
2020-04-07 09:27:35.621188 | ubuntu-bionic |
2020-04-07 09:27:35.621210 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/.tox/py36/lib/python3.6/site-packages/neutron/tests/base.py", line 182, in func
2020-04-07 09:27:35.621234 | ubuntu-bionic | return f(self, *args, **kwargs)
2020-04-07 09:27:35.621256 | ubuntu-bionic |
2020-04-07 09:27:35.621282 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/.tox/py36/lib/python3.6/site-packages/oslo_db/sqlalchemy/test_migrations.py", line 598, in test_models_sync
2020-04-07 09:27:35.621356 | ubuntu-bionic | "Models and migration scripts aren't in sync:\n%s" % msg)
2020-04-07 09:27:35.621385 | ubuntu-bionic |
2020-04-07 09:27:35.621410 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/networking-midonet/.tox/py36/lib/python3.6/site-packages/unittest2/case.py", line 690, in fail
2020-04-07 09:27:35.621434 | ubuntu-bionic | raise self.failureException(msg)
2020-04-07 09:27:35.621457 | ubuntu-bionic |
2020-04-07 09:27:35.621480 | ubuntu-bionic | AssertionError: Models and migration scripts aren't in sync:
2020-04-07 09:27:35.621502 | ubuntu-bionic | [ [ ( 'modify_type',
2020-04-07 09:27:35.621525 | ubuntu-bionic | None,
2020-04-07 09:27:35.621560 | ubuntu-bionic | 'midonet_tasks',
2020-04-07 09:27:35.621583 | ubuntu-bionic | 'data',
2020-04-07 09:27:35.621606 | ubuntu-bionic | { 'existing_comment': None,
2020-04-07 09:27:35.621631 | ubuntu-bionic | 'existing_nullable': True,
2020-04-07 09:27:35.621665 | ubuntu-bionic | 'existing_server_default': False},
2020-04-07 09:27:35.621689 | ubuntu-bionic | LONGTEXT(),
2020-04-07 09:27:35.621712 | ubuntu-bionic | Text())]]

Slawek Kaplonski (slaweq)
Changed in networking-midonet:
status: In Progress → Confirmed
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
importance: Undecided → Critical
tags: added: gate-failure
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

Patch is proposed already https://review.opendev.org/#/c/720788/

Changed in networking-midonet:
assignee: nobody → Slawek Kaplonski (slaweq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/726371

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.opendev.org/720788
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=86463fe85f106e95688bb505e7f14569dbbcea1b
Submitter: Zuul
Branch: master

commit 86463fe85f106e95688bb505e7f14569dbbcea1b
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Apr 17 17:38:39 2020 +0000

    Make gate great again

    This patch combines two fixes into one patch to fix UT failures:

    * Fix MidonetInterfaceDriver.plug_new signature

      Since [1], the "LinuxInterfaceDriver.plug_new" signature includes a
      new kwarg, "link_up". Because "MidonetInterfaceDriver" inherits from
      "LinuxInterfaceDriver" and overrides "plug_new" function, the local
      implementation should include this new parameter.

    * Fix Mysql db migration schema
      Field "midonet_tasks.data" was defined as sa.Text() in db model but in
      migration script for mysql engine it is defined as Text type with
      lenght long enough to create LONGTEXT field in the DB. That caused
      problem with types of field in the db model and migration script.
      So this patch fixes that by using sa.Text() with LONGTEXT variant for
      mysql engine in db model.

    [1]https://review.opendev.org/#/c/707406

    Co-Authored-By: Slawek Kaplonski <email address hidden>

    Change-Id: Ibab90934e138f10e36e055c038e404f89d01f41e
    Closes-Bug: #1871568

Changed in networking-midonet:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (stable/ussuri)

Reviewed: https://review.opendev.org/726371
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=84a3c8ff90e8af087840b58f03b1e3452a8c1ae0
Submitter: Zuul
Branch: stable/ussuri

commit 84a3c8ff90e8af087840b58f03b1e3452a8c1ae0
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Apr 17 17:38:39 2020 +0000

    Make gate great again

    This patch combines two fixes into one patch to fix UT failures:

    * Fix MidonetInterfaceDriver.plug_new signature

      Since [1], the "LinuxInterfaceDriver.plug_new" signature includes a
      new kwarg, "link_up". Because "MidonetInterfaceDriver" inherits from
      "LinuxInterfaceDriver" and overrides "plug_new" function, the local
      implementation should include this new parameter.

    * Fix Mysql db migration schema
      Field "midonet_tasks.data" was defined as sa.Text() in db model but in
      migration script for mysql engine it is defined as Text type with
      lenght long enough to create LONGTEXT field in the DB. That caused
      problem with types of field in the db model and migration script.
      So this patch fixes that by using sa.Text() with LONGTEXT variant for
      mysql engine in db model.

    [1]https://review.opendev.org/#/c/707406

    Co-Authored-By: Slawek Kaplonski <email address hidden>

    Change-Id: Ibab90934e138f10e36e055c038e404f89d01f41e
    Closes-Bug: #1871568
    (cherry picked from commit 86463fe85f106e95688bb505e7f14569dbbcea1b)

tags: added: in-stable-ussuri
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.