networking-midonet

unnecessary L3 rpcs

Bug #1525881 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
In Progress
Wishlist
YAMAMOTO Takashi
neutron
Won't Fix
Undecided
Kevin Benton

Bug Description

networking-midonet plugin currently issues RPCs for L3-agent unnecessarily.
they are unnecessary as the plugin doesn't use neutron L3-agent at all.
many (not all) of these RPCs are a consequence of using L3_NAT_db_mixin as a base class. the plugin should use L3_NAT_dbonly_mixin instead.

in order to do that, a few RPC assumptions in neutron needs to be fixed.
namely,
- ML2 uses disassociate_floatingips(do_notify), which is only available in L3_NAT_db_mixin
- a few l3 tests unnecessarily assume L3_NAT_db_mixin

See original description
YAMAMOTO Takashi (yamamoto)
description: updated
Changed in networking-midonet:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
milestone: none → 2.0.0
status: New → In Progress
description: updated
YAMAMOTO Takashi (yamamoto)
Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/257467

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/257468

Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

The description here is lacking detail. Please detail the RPC message which are unnecessary and the RCP assumptions being made.

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

Carl, i updated the description with some details.

description: updated
OpenStack Infra (hudson-openstack)
Changed in neutron:
status: Incomplete → In Progress
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
importance: Undecided → Wishlist
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: YAMAMOTO Takashi (yamamoto) → Kevin Benton (kevinbenton)
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
milestone: 2.0.0 → 3.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/257467
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

ping?

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/257468
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-midonet (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/257375
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
milestone: 3.0.0 → 4.0.0
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
milestone: 4.0.0 → none
Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.