Change neutronclient extension to use execute()
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| networking-cisco |
Fix Committed
|
Critical
|
Paul Michali | ||
| Liberty |
Fix Committed
|
Critical
|
Paul Michali | ||
| Mitaka |
Fix Committed
|
Critical
|
Paul Michali | ||
Bug Description
A recent change to neutronclient has caused a failure in tests for Liberty, where the networking-cisco LIberty code defines the get_data() method, and the neutronclient now uses take_action(). This is not an issue on Mitaka, where networking-cisco has been updated to work with the latest neutronclient take_action() method (a latent bug though).
The issue stems from the fact that neutron and neutronclient versions are independent, and there is no constraint on the neutronclient version (for good or bad). The neutronclient is backward compatible and the newer version works with current and older neutron versions.
However the client extension in networking-cisco is not using the public execute() method, and instead is using get_data(), which is a private method. Switching to take_action() will resolve the issue, but this too is a private method and would cause problems if an older neutronclient is used, or changes are made in the future.
The suggestion from Akihiro Mokoto is to use the public execute() method, instead, for both Liberty and Mitaka (master).
| Changed in networking-cisco: | |
| status: | New → Confirmed |
| importance: | Undecided → Critical |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to networking-cisco (master) | #1 |
| Changed in networking-cisco: | |
| status: | Confirmed → In Progress |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to networking-cisco (stable/liberty) | #2 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to networking-cisco (stable/liberty) | #3 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to networking-cisco (master) | #4 |
Fix proposed to branch: master
Review: https:/