networking-cisco

Cisco CSR1kv FWaaS driver should use 'l4-options' keyword instead of 'L4-option'

Bug #1463774 reported by Nikolay Fedotov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-cisco
New
Undecided
Unassigned
neutron
Fix Released
Undecided
Unassigned
neutron 7.0.0 "liberty"

Bug Description

CSR1kv REST API has been updated a little bit.

Example of POST request for https://10.0.200.12:55443/api/v1/acl:
{"rules": [{"l4-options": {"dest-port-start": "22"}, "protocol": "tcp", "sequence": "100", "destination": "any", "source": "any", "action": "permit"}, {"l4-options": {"src-port-start": "4510", "dest-port-start": "4510"}, "protocol": "udp", "sequence": "101", "destination": "any", "source": "any", "action": "permit"}]}

Notice "l4-options" keyword starts from lower-case letter.

Tags: fwaas
Yanping Qu (yanping)
Changed in neutron-fwaas (Ubuntu):
assignee: nobody → Yanping Qu (yanping)
Yanping Qu (yanping)
affects: neutron-fwaas (Ubuntu) → neutron
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Can you confirm that this is something that belongs to the neutron core, rather than the cisco driver?

Changed in neutron:
status: New → Incomplete
Revision history for this message
Yanping Qu (yanping) wrote :

This is an issue specific to Cisco FWaaS Driver

Yanping Qu (yanping)
summary: - Cisco CSR1kv device driver should use 'l4-options' keyword instead of
+ Cisco CSR1kv FWaaS driver should use 'l4-options' keyword instead of
'L4-option'
Sean M. Collins (scollins)
tags: added: fwaas
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: Yanping Qu (yanping) → Sean M. Collins (scollins)
status: Incomplete → In Progress
Sean M. Collins (scollins)
Changed in neutron:
assignee: Sean M. Collins (scollins) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/195253
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=63936a524d3077fbcd945a76d7bd1e52d026af82
Submitter: Jenkins
Branch: master

commit 63936a524d3077fbcd945a76d7bd1e52d026af82
Author: Yanping Qu <email address hidden>
Date: Wed Jun 24 11:24:35 2015 -0700

    Cisco CSR FWaaS driver should use 'l4-options' in CSR RESTAPI call

    This issue is found when testing CSR FWaaS with a newer CSR image.
    CSR ACL RESTAPI has been changed. The keyword "L4-options" is changed
    to "l4-options". CSR FWaaS driver code needs to be changed accordingly.

    (1) change "L4-options" to "l4-options" in CSR FWaaS driver code.
    (2) We don't need to take care of old "L4-options" anymore. We will document
    to suggest the right CSR images / versions to work with CSR FWaaS.
    (3) Add simple test data ("source_port" and "destinatin_port") to the
    fake firewall rule. The "l4-options" for CSR RESTAPI will be formed based
    on these test data.

    Change-Id: I3ab8cf603266c28cfd6278d813ceef389b7b82e6
    Closes-Bug: #1463774

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.