BaGPipe

[sqlalchemy-20] sfc driver failures

Bug #2025127 reported by Lajos Katona
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BaGPipe
Fix Released
Undecided
Lajos Katona

Bug Description

SqlAlchemy 1.4 deprecated the subtransactions=True parameter for session.begin():
  File "/home/zuul/src/opendev.org/openstack/networking-bagpipe/networking_bagpipe/db/sfc_db.py", line 86, in allocate_rt
    with self.session.begin(subtransactions=True):
TypeError: Session.begin() got an unexpected keyword argument 'subtransactions'

Tags: db
Lajos Katona (lajos-katona)
Changed in networking-bagpipe:
assignee: nobody → Lajos Katona (lajos-katona)
Lajos Katona (lajos-katona)
tags: added: db
OpenStack Infra (hudson-openstack)
Changed in networking-bagpipe:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to networking-bagpipe (master)

Reviewed: https://review.opendev.org/c/openstack/networking-bagpipe/+/891325
Committed: https://opendev.org/openstack/networking-bagpipe/commit/58efb3e21cce6b1661782377b08dfe5a2257788b
Submitter: "Zuul (22348)"
Branch: master

commit 58efb3e21cce6b1661782377b08dfe5a2257788b
Author: elajkat <email address hidden>
Date: Wed Aug 23 14:20:02 2023 +0200

    SQLAlchemy: add context wrappers to SFC driver

    With SQLAlchemy > 2.0.0 the unit tests of networking-bagpipe
    are unstable.
    The failure looks like some session violance, but more work
    is necessary as I still can't see where the root of the issue is.

    Change-Id: I5633d067e6ae4d9de89888a2587470715cd7b506
    Related-Bug: #1964575
    Related-Bug: #2025127

Changed in networking-bagpipe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bagpipe (master)

Reviewed: https://review.opendev.org/c/openstack/networking-bagpipe/+/879463
Committed: https://opendev.org/openstack/networking-bagpipe/commit/48f12c0019c5088a10b7c74c78eb821d29b7f402
Submitter: "Zuul (22348)"
Branch: master

commit 48f12c0019c5088a10b7c74c78eb821d29b7f402
Author: elajkat <email address hidden>
Date: Tue Apr 4 16:59:19 2023 +0200

    [sqlalchemy-20] Add the remaining context wrappers

    Add the remaining context wrappers to SFC driver and
    adapt the unit tests also for this change, and replace
    the deprecated assertDictContainsSubset call.

    Depends-On: https://review.opendev.org/c/openstack/networking-sfc/+/893660
    Change-Id: I0e19ed47e67fab474697c321f9a60ba5087c1c80
    Related-Bug: #2004265
    Closes-Bug: #2025127

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-bagpipe 19.0.0.0rc1

This issue was fixed in the openstack/networking-bagpipe 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.