Bug #1790461 “Replace communicate() function with check_output()...” : Bugs : BaGPipe

Replace communicate() function with check_output() for python3 compatiblity

Bug #1790461 reported by Yang Youseok
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BaGPipe
Fix Committed
Undecided
Unassigned

Bug Description

in common/run_command.py shell communicate() have output typed byte stream for python3.5. And this makes exception for further processing like split('-') in networking_bagpipe/bagpipe_bgp/vpn/dataplane_drivers.py since could not split with string parameter.

I think we have to decode the output or use the more appropriate for python3 compatibility.

Yang Youseok (ileixe)
description: updated
Revision history for this message
Thomas Morin (tmmorin-orange) wrote :

I think this is fixed by https://review.opendev.org/#/c/686489

Revision history for this message
Yang Youseok (ileixe) wrote :

Yes it looks like working now :)

Changed in networking-bagpipe:
status: New → In Progress
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Loading subscribers...

Remote bug watches

Bug watches keep track of this bug in other bug trackers.