MySQL Connector/Python

Connection.recv:buf size bug

Bug #551533 reported by seewind
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Connector/Python
Fix Released
Critical
Geert JM Vanderkelen
0.1
Fix Released
Critical
Geert JM Vanderkelen

Bug Description

sorry about my poor english.

the patch is:
=== (+24,-23) mysql/connector/connection.py ===
@@ -92,21 +92,22 @@
                 if pktnr == -1 and totalsize > 4:
                     pktsize = utils.intread(buf[0:3])
                     pktnr = utils.intread(buf[3])
- if pktnr > -1 and totalsize >= pktsize:
+ if pktnr > -1 and totalsize >= pktsize+4:
                     size = pktsize+4
+ #print '[mysql]recv:', size, pktnr, repr(buf)
                     self.buffer.append(buf[0:size])
                     buf = buf[size:]
                     pktnr = -1
                     if len(buf) == 0:
                         break
- elif len(buf) < pktsize:
+ elif len(buf) < pktsize+4:
                     buf += self.sock.recv(self.recvsize, self.socket_flags)

because size = pktsize+4, if totalsize >= pktsize and totalsize < pktsize+4, this bug is appear.

Related branches

lp://staging/myconnpy/0.1
Geert JM Vanderkelen: Pending requested
Diff: 979 lines (+377/-54) (has conflicts)
48 files modified
ChangeLog (+201/-2)
README (+4/-0)
make_release.py (+4/-0)
python2/examples/client.py (+4/-0)
python2/mysql/connector/__init__.py (+1/-1)
python2/mysql/connector/_version.py (+4/-0)
python2/mysql/connector/connection.py (+6/-2)
python2/mysql/connector/constants.py (+1/-1)
python2/mysql/connector/conversion.py (+2/-2)
python2/mysql/connector/cursor.py (+2/-2)
python2/mysql/connector/dbapi.py (+1/-1)
python2/mysql/connector/errors.py (+4/-0)
python2/mysql/connector/mysql.py (+1/-1)
python2/mysql/connector/protocol.py (+1/-1)
python2/mysql/connector/utils.py (+1/-1)
python2/tests/__init__.py (+2/-2)
python2/tests/test_bugs.py (+43/-1)
python2/tests/test_constants.py (+2/-2)
python2/tests/test_conversion.py (+2/-2)
python2/tests/test_cursor.py (+2/-2)
python2/tests/test_examples.py (+2/-2)
python2/tests/test_mysql_datatypes.py (+2/-2)
python2/tests/test_pep249.py (+1/-1)
python2/tests/test_protocol.py (+1/-1)
python2/tests/test_utils.py (+1/-1)
python3/mysql/connector/__init__.py (+1/-1)
python3/mysql/connector/_version.py (+4/-0)
python3/mysql/connector/connection.py (+6/-2)
python3/mysql/connector/constants.py (+1/-1)
python3/mysql/connector/conversion.py (+1/-1)
python3/mysql/connector/cursor.py (+1/-1)
python3/mysql/connector/dbapi.py (+1/-1)
python3/mysql/connector/errors.py (+1/-1)
python3/mysql/connector/mysql.py (+1/-1)
python3/mysql/connector/protocol.py (+1/-1)
python3/mysql/connector/utils.py (+1/-1)
python3/tests/__init__.py (+1/-1)
python3/tests/test_bugs.py (+43/-1)
python3/tests/test_constants.py (+2/-2)
python3/tests/test_conversion.py (+2/-2)
python3/tests/test_cursor.py (+1/-1)
python3/tests/test_examples.py (+2/-2)
python3/tests/test_mysql_datatypes.py (+1/-1)
python3/tests/test_pep249.py (+1/-1)
python3/tests/test_protocol.py (+1/-1)
python3/tests/test_utils.py (+1/-1)
setup.py (+4/-0)
unittests.py (+4/-0)
lp://staging/~geertjmvdk/myconnpy/main
Geert JM Vanderkelen (geertjmvdk)
Changed in myconnpy:
assignee: nobody → Geert JM Vanderkelen (geertjmvdk)
Revision history for this message
Geert JM Vanderkelen (geertjmvdk) wrote :

Thanks for this bug report and patch.
I'm not able to find a good case to reproduce problems. Do you have away to cause problems without patching this code?

Changed in myconnpy:
status: New → Incomplete
Revision history for this message
Geert JM Vanderkelen (geertjmvdk) wrote :

Got a test case with bug report #586003!

Thanks for this bug report, now I can repeat it.

Changed in myconnpy:
importance: Undecided → Critical
status: Incomplete → In Progress
Revision history for this message
Geert JM Vanderkelen (geertjmvdk) wrote :

revno: 240
committer: Geert Vanderkelen <email address hidden>
branch nick: myconnpy-bug-lp586003
timestamp: Thu 2010-05-27 11:05:59 +0200
message:
  Critical bug fix: impossible to select big results

  o It was impossible to select big result sets.
  o Fixed for both Python2 and Python3.
  o Added test case for bug lp:586003 and lp:551533

Changed in myconnpy:
status: In Progress → Fix Committed
Geert JM Vanderkelen (geertjmvdk)
Changed in myconnpy:
status: Fix Committed → Fix Released
status: Fix Released → In Progress
Revision history for this message
Geert JM Vanderkelen (geertjmvdk) wrote :

Merged into trunk rev248

Changed in myconnpy:
status: In Progress → Fix Committed
Geert JM Vanderkelen (geertjmvdk)
Changed in myconnpy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.