Unable to deploy windows machines with cloudbase-init

Bug #1595863 reported by Jose Phillips
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Jose Phillips
Liberty
New
Undecided
Unassigned
Mitaka
Fix Committed
High
Unassigned
Newton
Fix Released
High
Jose Phillips

Bug Description

Deploying a Windows based Virtual machine with Murano and cloudbase-init fails because Murano Core Library windows-init.ps1 have the command interpreter after Licensing information.

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

#ps1

should be

#ps1

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

Changed in murano:
assignee: nobody → josephillips (jose-phillips)
Revision history for this message
Jose Phillips (jose-phillips) wrote :
Changed in murano:
status: New → In Progress
Changed in murano:
status: In Progress → New
Revision history for this message
maestropandy (maestropandy) wrote :

Share C:\Murano\Agent\log.txt

Revision history for this message
maestropandy (maestropandy) wrote :

Also C:\Murano\PowerShell.log

Revision history for this message
Jose Phillips (jose-phillips) wrote :

Hi
log.txt and powershell.log are not populated cuz the agent can't execute

this is happening because Cloudbase-init can't parse the windows-init.ps1 in cloudbase-init logs i got this error.

 WARNING cloudbaseinit.plugins.common.userdatautils [-] Unsupported user_data format

Checking the code of cloudbase-init on user

# Avoid 80+ length by using a local variable, which
# is deleted afterwards.
_compile = functools.partial(re.compile, flags=re.I)
FORMATS = (
    (_compile(br'^rem\s+cmd\s'), execcmd.Shell),
    (_compile(br'^#!\s*/usr/bin/env\s+python\s'), execcmd.Python),
    (_compile(br'^#!'), execcmd.Bash),
    (_compile(br'^#(ps1|ps1_sysnative)\s'), execcmd.PowershellSysnative),
    (_compile(br'^#ps1_x86\s'), execcmd.Powershell),
    (_compile(br'</?(script|powershell)>'), execcmd.EC2Config),

)

for me made me sense put the interpreter #ps1 at the beginning of the file instead after the licensing information.

Stan Lagun (slagun)
Changed in murano:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334016

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/334099

Changed in murano:
milestone: none → newton-2
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/334016
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d8ccb215bed519889e966d3d39ccbfe1eab1e174
Submitter: Jenkins
Branch: master

commit d8ccb215bed519889e966d3d39ccbfe1eab1e174
Author: Jose Phillips <email address hidden>
Date: Fri Jun 24 12:37:09 2016 -0500

    Fix issue with deployment with cloudbase-init on Windows

    Change-Id: Ie7908035d7b8b5c763239cca837b436dde115174
    Closes-Bug: #1595863

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/mitaka)

Reviewed: https://review.openstack.org/334099
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=2bb6db43499553f70b3400fbc80cac8223779f6f
Submitter: Jenkins
Branch: stable/mitaka

commit 2bb6db43499553f70b3400fbc80cac8223779f6f
Author: Jose Phillips <email address hidden>
Date: Fri Jun 24 12:37:09 2016 -0500

    Fix issue with deployment with cloudbase-init on Windows

    Change-Id: Ie7908035d7b8b5c763239cca837b436dde115174
    Closes-Bug: #1595863

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/murano 3.0.0.0b2

This issue was fixed in the openstack/murano 3.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 2.0.2

This issue was fixed in the openstack/murano 2.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.