[dashboard] descriptions of fields (for example license/requirements) should be limited in UI.

Bug #1465315 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Low
omar
Mitaka
Fix Committed
Low
Kirill Zaitsev
Newton
Fix Released
Low
omar
OpenStack Dashboard (Horizon)
Invalid
Undecided
Unassigned

Bug Description

To reproduce: add a long license description.

https://www.dropbox.com/s/40d86ct7ww18w5z/Screenshot%202015-06-15%2017.37.08.png?dl=0

This looks cluttered and makes little sense.

Changed in murano:
status: New → Confirmed
Changed in murano:
milestone: liberty-1 → liberty-2
Changed in murano:
milestone: liberty-2 → liberty-3
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

Kirill, we should provide alternative way to add information to description

Changed in murano:
milestone: liberty-3 → liberty-rc1
summary: - [dashboard] descriptions of hidden fields (for example
- license/requirements) should be hidden as well.
+ [dashboard] descriptions of fields (for example license/requirements)
+ should be limited in UI.
Changed in murano:
milestone: liberty-rc1 → next
zhurong (zhu-rong)
Changed in murano:
assignee: nobody → zhu.rong (zhu-rong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226669

Changed in murano:
status: Confirmed → In Progress
Changed in murano:
milestone: next → liberty-rc1
Changed in murano:
milestone: liberty-rc1 → mitaka-1
Changed in murano:
assignee: zhu.rong (zhu-rong) → nobody
Changed in murano:
milestone: mitaka-1 → mitaka-2
Changed in murano:
status: In Progress → Confirmed
Changed in murano:
milestone: mitaka-2 → mitaka-3
Changed in murano:
milestone: mitaka-3 → mitaka-rc1
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

This is not a bug in Horizon. If you have entered a description that is too long, make it smaller. This data is not readable anywhere else, so capping its display doesnt make sense.

Changed in horizon:
status: New → Invalid
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

This indeed was never a bug in horizon. Rob, can you maybe remove horizon completely from this bug, so that we would not spam you with updates?

omar (oshykhkerimov)
Changed in murano:
assignee: nobody → omar (oshykhkerimov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/293094

Changed in murano:
status: Confirmed → In Progress
Changed in murano:
milestone: mitaka-rc1 → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/293094
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=c2e0102c4bc471bed21fbd69dcea6aefab0ef768
Submitter: Jenkins
Branch: master

commit c2e0102c4bc471bed21fbd69dcea6aefab0ef768
Author: Omar Shykhkerimov <email address hidden>
Date: Tue Mar 15 20:58:13 2016 +0200

    Hide extra text in descriptions and allow expanding

    Previously every description was shown fully and it caused troubles
    in case of large descriptions.

    For now every description is covered in div tag. js-handler provides
    code to create and control links to expand and compress these fields.

    Change-Id: I3bb64382b48d1435dea20bccea96836d3d2015da
    Closes-Bug: #1465315

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on murano-dashboard (master)

Change abandoned by zhurong (<email address hidden>) on branch: master
Review: https://review.openstack.org/226669
Reason: abandon

tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322144

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/mitaka)

Reviewed: https://review.openstack.org/322144
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=d993037584bd52ad559241b276edad30a13e9142
Submitter: Jenkins
Branch: stable/mitaka

commit d993037584bd52ad559241b276edad30a13e9142
Author: Omar Shykhkerimov <email address hidden>
Date: Tue Mar 15 20:58:13 2016 +0200

    Hide extra text in descriptions and allow expanding

    Previously every description was shown fully and it caused troubles
    in case of large descriptions.

    For now every description is covered in div tag. js-handler provides
    code to create and control links to expand and compress these fields.

    Change-Id: I3bb64382b48d1435dea20bccea96836d3d2015da
    Closes-Bug: #1465315
    (cherry picked from commit c2e0102c4bc471bed21fbd69dcea6aefab0ef768)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 3.0.0.0b1

This issue was fixed in the openstack/murano-dashboard 3.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 2.0.1

This issue was fixed in the openstack/murano-dashboard 2.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.