Murano

Update task in the Service Actions API references invalid Session State

Series liberty
Bug #1629361

Bug #1629361 reported by Felipe Monteiro on 2016-09-30

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Murano	Fix Released	High	Felipe Monteiro	Murano 3.1.0
Liberty	New	Undecided	Unassigned
Mitaka	Fix Committed	High	Felipe Monteiro	Murano 2.0.x "2.0.x"
Newton	Fix Committed	High	Felipe Monteiro	Murano 3.0.0
Ocata	Fix Released	High	Felipe Monteiro	Murano 3.1.0

Bug Description

Currently, the function update_task in murano.services.actions references the invalid variable 'states.SessionState.deploying'. However, the correct variable is 'states.SessionState.DEPLOYING' as defined in murano.services.states.

The following traceback is produced:

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/opt/stack/mitaka-murano-gerrit/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
        return func(*args, **keywargs)
      File "murano/tests/unit/services/test_actions.py", line 88, in test_update_task
        mock_task, mock_unit)
      File "murano/services/actions.py", line 46, in update_task
        session.state = states.SessionState.deploying
    AttributeError: 'SessionState' object has no attribute 'deploying'

Felipe Monteiro (fm577c) on 2016-09-30

Changed in murano:
assignee:	nobody → Felipe Monteiro (fm577c)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/380375

Kirill Zaitsev (kzaitsev) on 2016-09-30

Changed in murano:
milestone:	none → ocata-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix proposed to murano (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/380397

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix proposed to murano (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/380402

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/380407

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Change abandoned on murano (master)

Change abandoned by Felipe Monteiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/380407

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Related fix proposed to murano (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/380505

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Fix merged to murano (master)

Reviewed: https://review.openstack.org/380375
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=bf586063f3bc3c3c7f8970852b5234a49cde4aae
Submitter: Jenkins
Branch: master

commit bf586063f3bc3c3c7f8970852b5234a49cde4aae
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:19:01 2016 -0400

Fix invalid SessionState.deploying reference in services actions.

Currently, update_task in murano.services.actions references
SessionState.deploying, which is invalid.

Change-Id: Idab7138c877e10987e7edf2c3a845897b2219a93
Closes-Bug: #1629361

Changed in murano:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Fix merged to murano (stable/mitaka)

Reviewed: https://review.openstack.org/380402
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=94f610a383bd2b0e0358bbb3fbb861d984f73cfd
Submitter: Jenkins
Branch: stable/mitaka

commit 94f610a383bd2b0e0358bbb3fbb861d984f73cfd
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:47:30 2016 -0400

Fix invalid SessionState.deploying reference in services actions.

Currently, update_task in murano.services.actions references
SessionState.deploying, which is invalid.

Change-Id: I414eacb323b5c905b5a76a871ab7f4df8751e9b9
Closes-Bug: #1629361

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Fix merged to murano (stable/newton)

Reviewed: https://review.openstack.org/380397
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=3365d22714366c327ea3427bb54ac7ca9e4ae5d5
Submitter: Jenkins
Branch: stable/newton

commit 3365d22714366c327ea3427bb54ac7ca9e4ae5d5
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:45:18 2016 -0400

Fix invalid SessionState.deploying reference in services actions.

Currently, update_task in murano.services.actions references
SessionState.deploying, which is invalid.

Change-Id: Ideab3cf42ffc525dc133d4e1f5307a09c2293511
Closes-Bug: #1629361

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Related fix proposed to murano (master)

#10

Related fix proposed to branch: master
Review: https://review.openstack.org/381229

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Change abandoned on murano (master)

#11

Change abandoned by Felipe Monteiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/381229
Reason: Redundant, see: https://review.openstack.org/#/c/380505/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-03: Related fix merged to murano (master)

#12

Reviewed: https://review.openstack.org/380505
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=a278164ce2b1997f96093bebb7363c7fa707895f
Submitter: Jenkins
Branch: master

commit a278164ce2b1997f96093bebb7363c7fa707895f
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 15:03:01 2016 -0400

Increase unit test coverage for Services Actions API.

    Commit includes:
    * Removed skip for test_update_task b/c related bug
      has been resolved.

    Implements bp: murano-unit-test-coverage
    Co-Authored-By: David Purcell <email address hidden>
    Co-Authored-By: Samantha Blanco <email address hidden>
    Co-Authored-By: Julian Sy <email address hidden>

Change-Id: Iccae718d528d410afdd13cfd09cb385af7f2d338
Related-Bug: #1629361

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-25: Fix included in openstack/murano 3.1.0

#13

This issue was fixed in the openstack/murano 3.1.0 release.