Include original ObjectsCopy/Attributes in exception_result
Before if an exception occured during dsl cleanup exception_result would
use empty ObjectsCopy and empty Attributes for result. In case exception
happened during env deletion this would cause env to be deleted by API,
because it ignored isException and treated any result as valid.
Now exception_result also includes original ObjectsCopy/Attributes in case
they're empty in exception_result.
Api not only checks count of 'error' statuses, in session, but also
checks isException attribute of the result, and treats exception results
as Errors, therefore marking deployment/deletion as failed.
Logging of results in API is now aware, that objects can be empty during
app deletion and no longer throws AttributeError because of that.
Change-Id: Idec8191ee25d1cac606741673719bbb8a72709b0
Closes-Bug: #1456724
(cherry picked from commit 1e62fafe8212a1e2eb4d5f2bad3da2d8c88a33fe)
Reviewed: https:/ /review. openstack. org/208957 /git.openstack. org/cgit/ openstack/ murano/ commit/ ?id=87a89dbda14 b8306f181fdffef 41ac3f0b87a628
Committed: https:/
Submitter: Jenkins
Branch: stable/kilo
commit 87a89dbda14b830 6f181fdffef41ac 3f0b87a628
Author: Kirill Zaitsev <email address hidden>
Date: Thu Jun 4 20:50:14 2015 +0300
Include original ObjectsCopy/ Attributes in exception_result
Before if an exception occured during dsl cleanup exception_result would
use empty ObjectsCopy and empty Attributes for result. In case exception
happened during env deletion this would cause env to be deleted by API,
because it ignored isException and treated any result as valid.
Now exception_result also includes original ObjectsCopy/ Attributes in case
they're empty in exception_result.
Api not only checks count of 'error' statuses, in session, but also
checks isException attribute of the result, and treats exception results
as Errors, therefore marking deployment/deletion as failed.
Logging of results in API is now aware, that objects can be empty during
app deletion and no longer throws AttributeError because of that.
Change-Id: Idec8191ee25d1c ac606741673719b bb8a72709b0 2eb4d5f2bad3da2 d8c88a33fe)
Closes-Bug: #1456724
(cherry picked from commit 1e62fafe8212a1e