Unit test failing for Neutron for stable 8.0 branch

As long as cliff.Command.take_action is abstract (see https://github.com/openstack/cliff/blob/master/cliff/command.py#L41) and ProbeCommand classes subclasses cliff.Command (see https://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/__init__.py#L393) cliff command guidelines should be followed and all run() methods be renamed to take_action().

Some more prooflinks:
* master vs openstack-ci/fuel-8.0/liberty diff: http://paste.openstack.org/show/490762/
* a similar problem in neutronclient: https://bugs.launchpad.net/python-neutronclient/+bug/1532258
* Cliff docs http://docs.openstack.org/developer/cliff/classes.html

Fix proposed to branch: stable/liberty
Change author: Inessa Vasilevskaya <email address hidden>
Review: https://review.fuel-infra.org/18174

Change abandoned by Inessa Vasilevskaya <email address hidden> on branch: stable/liberty
Review: https://review.fuel-infra.org/18174
Reason: Oops, wrong branch

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Inessa Vasilevskaya <email address hidden>
Review: https://review.fuel-infra.org/18175

Change abandoned by Oleg Bondarev <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/18187
Reason: This has upstream dependencies

This is critical because blocks any further commits to be merged since unit-tests are broken by incorrect dependency of python-neutronclient which should not be greater than 3.1.0. But in all failed tests we see neutronclient versions > 4.0.0. This is weird and should be fixed asap.

Looks like WebOb is also culprit, we expect WebOb==1.5.1 but in unit-tests we started getting 1.6.0.

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Oleg Bondarev <email address hidden>
Review: https://review.fuel-infra.org/18196

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Inessa Vasilevskaya <email address hidden>
Review: https://review.fuel-infra.org/18199

Fix proposed to branch: master
Change author: Sergey Kolekonov <email address hidden>
Review: https://review.fuel-infra.org/18201

Change abandoned by Inessa Vasilevskaya <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/18175
Reason: wrong approach

Reviewed: https://review.fuel-infra.org/18201
Submitter: Aleksandra Fedorova <email address hidden>
Branch: master

Commit: 5448a2d8cf26a93f9fc6a13fdfc6d1663532ab1b
Author: Sergey Kolekonov <email address hidden>
Date: Thu Mar 17 16:40:36 2016

Pin webob and neutronclient

Currently unit tests don't work on patches uploaded to
openstack-ci/fuel-8.0/liberty branch. python-webob and python-neutronclient
should be pinned to correct versions

Change-Id: I6745b14ec4adf6129458f9425bc534c54e7f26c0
Closes-bug: #1558086

Looks like changing just mos-requirements doesn't solve the problem, we still get the newest libraries somewhere from Pypi and ignore pinned ones. Reassigning to mos-packaging team to understand what is going on with devops script for run unit tests for MOS code.

Here is an example of failed tests with updated mos-requirements: https://review.fuel-infra.org/#/c/17990/

Looks like job is ignoring constraints event they set.
Asked for installation:

09:17:18 Release constraints:
09:17:18 ========================================
09:17:18 astroid==1.3.8 #astroid 1.3.8 python-astroid 1.3.8-1 archive.ubuntu.com--trusty--main
09:17:18 WebOb==1.5.1 #python-webob 1.5.1-1 archive.ubuntu.com--trusty--main
09:17:18 python-neutronclient==3.1.0 #python-neutronclient 3.1.0-1~u14.04+mos9 perestroika-repo-tst.infra.mirantis.net--mos8.0--main
09:17:18 ========================================

Installed:
09:29:52 WebOb==1.6.0
09:29:52 python-neutronclient==4.1.1 # git sha 8fe5386

This change should fix problem https://review.fuel-infra.org/#/c/18298/

Problem was caused by additional install command in tox.ini which install python module directly from neutron directory:
pip install -U {opts} {packages}

In logs it looks like this:
16:57:07 /home/jenkins/workspace/gate-neutron-python27$ /home/jenkins/workspace/gate-neutron-python27/.tox/py27/bin/pip install -U -e /home/jenkins/workspace/gate-neutron-python27 >/home/jenkins/workspace/gate-neutron-python27/.tox/py27/log/py27-3.log

In this step constrains are not used then pip upgrade packages to versions from original requirements.txt.

Simplest solution is to disable upgrade option, which should install only missed packages.

Moving this bug under maintenance team responsibility since they will finally decide if this patch works for them.

Change restored by Sergii Rizvan <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/18187

Reviewed: https://review.fuel-infra.org/18187
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: 0b747de4b6ab004ed2f687119bf4adad23a8c8fd
Author: Oleg Bondarev <email address hidden>
Date: Thu Mar 17 11:03:47 2016

Make all tox targets constrained

Since neutron gate already switched to -constraints target, we need to
keep those targets until we switch gate back to using targets without
the postfix.

This change effectively makes both types of targets identical.

Note: override install_command for venv, releasenotes, and cover targets
since corresponding gate jobs do not provide constraints file yet.

Also removed cover-constraints target since it would never work in gate
anyway.

Conflicts:
 tools/tox_install.sh
 tox.ini

Liberty changes:
- tools/tox_install.sh not present in the branch; instead of backporting
  it, use pip install -U directly.

Upstream review: https://review.openstack.org/#/c/289280
Closes-Bug: #1558086
Co-Authored-By: Ihar Hrachyshka <email address hidden>
Co-Authored-By: Andreas Jaeger <email address hidden>
Change-Id: Ica2d509df0c54496aba7cb3162565384cc5d34c8

Change abandoned by Alexander Ignatov <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/18199
Reason: not needed anymore