Mojo chokes on buggy/undefined nagios checks
Bug #1803030 reported by
Barry Price
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mojo: Continuous Delivery for Juju |
Fix Committed
|
Low
|
Barry Price | ||
Bug Description
Obviously they shouldn't exist in the first place, but Mojo doesn't cope well if a buggy charm has left half-defined check definitions on disk, e.g.:
command[
This results in Mojo crashing with:
bash: line 7: syntax error near unexpected token `&&'
bash: line 7: `(set -x; && echo MOJO_NAGIOS_OK) || echo MOJO_NAGIOS_FAIL '
The linked MP should exclude any undefined/empty checks.
Related branches
lp://staging/~barryprice/mojo/mojo
- Tom Haddon: Approve
- Barry Price: Needs Resubmitting
- Mojo Maintainers: Pending requested
-
Diff: 56 lines (+24/-1)2 files modifiedmojo/phase.py (+5/-0)
mojo/tests/test_phase.py (+19/-1)
| Changed in mojo: | |
| assignee: | nobody → Barry Price (barryprice) |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| importance: | Medium → Low |
Revision history for this message
| Junien Fridrick (axino) wrote | #1 |
Revision history for this message
| Barry Price (barryprice) wrote | #2 |
| Changed in mojo: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
I think it's good that Mojo chokes on these, it helps us identify charm bugs.