sd8686 driver: scanning signal quality problems

Updating status for acton to critical as the driver is not providing standard information used in the UI. Need to schedule meeting to discuss resolution plan.

I checked the code, and found Marvell original code always return 0 for the "quality". I have pinged Marvell for this, no response yet.

Following is some raw feedback got from Marvell FAE

=======================================================================
=======================================================================

This appears to be a cosmetic bug; in order to look into this I would
need more information from you:
 > The Silicon revision you are using.
 > The Marvell Driver version you are using.

Meanwhile I would recommend you to take a look at alternative command to
"iwconfig" that can give you the link quality information:

iwpriv ethX getSNR <n>
iwpriv ethX getNF <n>
iwpriv ethX getRSSI <n>

The bellow explanation is taken from the README file:

"getSNR
 This command gets the average and non average value of Signal to
Noise Ratio of Beacon and Data.

 where value is:
   0 -- Beacon non-average.
          1 -- Beacon average.
          2 -- Data non-average.
          3 -- Data average.

 If no value is given, all four values are returned in the order
mentioned above.

 Note: This command is available only when STA is connected.

getRSSI
 This command gets the average and non average value os Receive
Signal Strength of Beacon and Data.

 where value is:
   0 -- Beacon non-average.
          1 -- Beacon average.
          2 -- Data non-average.
          3 -- Data average.

 Note: This command is available only when STA is connected.

getNF
 This command gets the average and non average value of Noise
Floor of Beacon and Data.

 where value is:
   0 -- Beacon non-average.
          1 -- Beacon average.
          2 -- Data non-average.
          3 -- Data average.

 Note: This command is available only when STA is connected."

I believe these commands can deliver the information you are looking
for, specially " iwpriv ethX getRSSI <n>"

All of the above private ioctls have notes stating:

"This command is available only when the STA is connected."

The signal quality discussed in the bug description is a per-scan result signal quality.

Don - assigning to you.

The following is an excerpt from an email I sent to Craig Roberts over the weekend that details the source file and line of code that needs to be changed...

The gnome-system-tools network-admin application is using the standard wireless extensions API to get scan results.

Scanning is trigged via the SIOSIWSCAN ioctl.

Scan results can be read via the SIOCGIWSCAN ioctl which triggers a series of wireless events which contain information for each access point found during the scan.

The bug is in both marvell sd868x drivers; in the file wlan_scan.c.

Search for the line:

iwe.cmd = IWEVQUAL;

You'll notice two lines later that quality is set to 0.

iwe.u.qual.qual = 0;

This is the line of code that needs to change. I don't have the details of how quality should be calculated. The following document might help:

http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/Tools.html

It also might be helpful to look at what some of the other kernel wi-fi drivers do ( or maybe even madwifi.org ).

Fix released in rc0.