legacyskinparser.cpp LegacySkinParser::parseBackground check NULL
Bug #914240 reported by
Daniel Lindenfelser
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Low
|
Daniel Lindenfelser | ||
Bug Description
legacyskinparse
if (background != NULL) {
is not correct use
if (!background-
Related branches
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #1 |
| Changed in mixxx: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Daniel Lindenfelser (dan-lin) wrote | #2 |
| Changed in mixxx: | |
| status: | Confirmed → Fix Committed |
| Changed in mixxx: | |
| assignee: | nobody → Daniel Lindenfelser (dan-lin) |
| status: | Fix Committed → In Progress |
| milestone: | none → 1.11.0 |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
Since background is a pointer, it should have a NULL check before dereferencing.
if (background != NULL && !background-
}
would be an option, but I assume that QLabel::setPixmap would ignore null or empty pixmaps anyway.