searching playlists does not work

Bug #887811 reported by Jens Nachtigall
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
RJ Skerry-Ryan
1.10
Fix Released
High
RJ Skerry-Ryan
1.9
Fix Committed
High
RJ Skerry-Ryan

Bug Description

in mixxx1.10beta: Searchin in crates works fine, but if I enter a "title" or whatever for searchin in a playlist, it does not have any effect at all. Even while searching still all playlist items are shown

Related branches

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → High
Revision history for this message
Lily (starlily) wrote :

Unable to reproduce on my Mac (Snow Leopard). I was able to search in Playlists , Crates, and Library.

Revision history for this message
Jens Nachtigall (nachtigall) wrote : Re: [Bug 887811] Re: searching playlists does not work

Am 25.11.2011 18:29, schrieb Lily:
> Unable to reproduce on my Mac (Snow Leopard). I was able to search in
> Playlists , Crates, and Library.

I do actually refer to playlists only, library and crates does also work
for me. This is with mixxx 1.10 beta1 on Ubuntu and is totally
reproducable in my case. Hmh, strange, are you also using the latest
beta of mixxx?

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: New → Confirmed
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

How embarrassing :) thanks for the report Jens. Not sure how that one slipped through. Unfortunately 1.9.2 is affected.

Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
Jens Nachtigall (nachtigall) wrote :

Am 27.11.2011 08:14, schrieb RJ Ryan:
> How embarrassing :) thanks for the report Jens. Not sure how that one
> slipped through. Unfortunately 1.9.2 is affected.

I am sorry that I haven't got the time to help out more.

It would probably be a very good to have some kind of unit testing
within the mixxx code basis, since many bugs seem to be regression bugs,
i.e. things that were working before get suddenly broken due to some new
feature or refactoring of code. Setting that up is extra work at first,
but in the long run it saves a lot of time.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I couldn't agree more! We actually have a unit testing system in Mixxx..
the code is in src/test/. You just compile with "scons test=1" to build it.

The only problem is... nobody writes tests! :) I've been thinking about
doing something mean like require comprehensive tests for every feature
branch that is merged. The time I waste hunting down regressions is huge.

On Sun, Nov 27, 2011 at 5:09 AM, Jens Nachtigall <email address hidden> wrote:

> Am 27.11.2011 08:14, schrieb RJ Ryan:
> > How embarrassing :) thanks for the report Jens. Not sure how that one
> > slipped through. Unfortunately 1.9.2 is affected.
>
> I am sorry that I haven't got the time to help out more.
>
> It would probably be a very good to have some kind of unit testing
> within the mixxx code basis, since many bugs seem to be regression bugs,
> i.e. things that were working before get suddenly broken due to some new
> feature or refactoring of code. Setting that up is extra work at first,
> but in the long run it saves a lot of time.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/887811
>
> Title:
> searching playlists does not work
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/887811/+subscriptions
>

Revision history for this message
Jens Nachtigall (nachtigall) wrote :

Am 27.11.2011 11:19, schrieb RJ Ryan:
> I've been thinking about
> doing something mean like require comprehensive tests for every feature
> branch that is merged.

I do not think that is mean but rather a standard for good software
developement :-D Many other projects work like this. Also before you
fix a bug, you first write the corresponding unit test, then fix it and
you'll save from this bug for the rest of your time.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
naught101 (naught101) wrote :

Is there a reason why you can't search in the Auto DJ playlist though?

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Yes, it's possibly a silly reason. The AutoDJ processor uses the same "view" on the database as the playlist shown in the GUI to decide what track to play next. So if you search that filters the view and the AutoDJ processor will play the next song in your search results, not in the playlist.

This would be easy to change. However -- back when you could search AutoDJ I would sometimes forget I had typed a search query (i.e. something that matches a lot of tracks so it wasn't as easy to notice some were missing) and had the wrong impression of what songs were coming up because of it. So usability is another reason we disable search and sorting in autodj.

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6090

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.