wishlist: Naming hot cues

For reference , there is already is similar wishlist bug filed wich would , if implemented, inevitably contain this feature.
Leaving this one as separate wishlist bug.

loop & cue sets
https://bugs.launchpad.net/mixxx/+bug/717841

An other aspect of this bug, with GUI mock-up http://www.mixxx.org/forums/viewtopic.php?f=1&t=4964

we may use http://www.djnotation.org/ by default.

I'll try to implement this.
I suggest (this implies other changes beyond this particular bug):

-Cues have names.
-Cues can be either cue points or "cue regions" (that is a start and an end point, like a loop).
-Cue regions can be either loop regions or not.
-Cues can be mapped to a hotcue slot if they are meant to be accessed live, otherwise are just visual marks on the waveforms.

So the big picture is that users can put plenty of different cues in their tracks and then choose which ones will be accessible from the hotcue controls.

Later on we can work on cue sets. I think this fits all the mentioned use cases well enough.

As you've probably already found some of the groundwork for this is already laid :)

* Mixxx treats loops and cues as the same type at the storage layer (the Cue class is used for storing loops too).
* Cues already have a user-editable label (it's not shown anywhere in the UI though)
* Cues are already mapped to a hotcue slot by the "hotcue" property of Cue.

Also make sure to checkout the very simplistic cue editor in the track properties. You can edit which hotcue a cue is assigned to and its label. It's super clunky though and could really use improvement.

In your other bug regarding a cue list widget you say you'd like to treat loops and cues as the same thing in the UI. It strikes me that that could be confusing in practice if you hit a hotcue and a loop starts. What was your plan re: loops here?

Cool, Thank you.
If possible, issue please pull requests in reasonable testable steps.

There are alse some related bugs you should be aware of:
https://bugs.launchpad.net/mixxx/+bug/890423
https://bugs.launchpad.net/mixxx/+bug/673515
https://bugs.launchpad.net/mixxx/+bug/717841
https://bugs.launchpad.net/mixxx/+bug/1367162

Yeah it's easy when everything is already done :). Right now I'm looking at how to append the (conveniently truncated) cue name to the hot-cue number that is already shown in the waveforms. This should be a first (partial) solution to the bug. Then I'll take a look at how cues without assigned hot-cues should be treated and extend the waveform visualization to them.

I have also planed to think about how the cue editing work-flow should be distributed between the editor in track properties and the deck.

What I meant in the other bug is that Serato keeps two separate lists for cue points and loop-cues but I think is better to put all cues together and let the user order them as he/she pleases. This way we support people willing to have a clear distinction between loops and cue points while also supporting people willing to have their cues laid in a chronological order. For sure we should provide a visual distinction between cue points and loops, an icon maybe?

Ok, step by step. Thank you.

2015-01-05 16:56 GMT+01:00 Daniel Schürmann <email address hidden>:

> Cool, Thank you.
> If possible, issue please pull requests in reasonable testable steps.
>
> There are alse some related bugs you should be aware of:
> https://bugs.launchpad.net/mixxx/+bug/890423
> https://bugs.launchpad.net/mixxx/+bug/673515
> https://bugs.launchpad.net/mixxx/+bug/717841
> https://bugs.launchpad.net/mixxx/+bug/1367162
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/807288
>
> Title:
> wishlist: Naming hot cues
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> I have noticed that the songs can already be cued, and I was thinking
> that it would be a great idea to have naming of each hot cue in the
> song. I see this as a very interesting feature because I think this
> could be used to identify mixing points within a song and make it very
> easy to mix.
>
> Thank you!!
> jaime11
>
> Posts: 2
> Joined: Wed Jul 06, 2011 6:00 pm
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/807288/+subscriptions
>

--
Ferran Pujol Camins

Just for the record: a pull request solving this is ready.

Can you tell the status of the bug. Since the las activity was over a year, if its incomplete and nobody is working on it anymore I would like to take it up.

Hey Kartik, the bug is partially solved:
So far I've managed the label to be rendered in the waveform (I want to clean the code a bit, that's why not merged yet).
Next step for me would be to also render the label in the hot cue buttons.

I you need this for GSOC I'm more than happy to spend some time soon to polish this and make it available to you.

Yes, I wanted to work on this to know about the code before applying for gsoc. Can you please do the remaining things as soon as possible and also post a link to the current pull request so that I can read it and learn a bit about the code?. In case you wont be able to do it, I ll be more than happy to do that :)

Ferran, do you mean you want to change the label of the hotcue buttons on screen to display the label? I don't think that would be such a great idea because labels could be quite long and mess with the layout of the skin. I think just displaying the label on the waveforms is fine.

I'll do ASAP. Please remind me if I take too long :)

2016-03-09 18:09 GMT+01:00 Kartik Gupta <email address hidden>:

> Yes, I wanted to work on this to know about the code before applying for
> gsoc. Can you please do the remaining things as soon as possible and
> also post a link to the current pull request so that I can read it and
> learn a bit about the code?. In case you wont be able to do it, I ll be
> more than happy to do that :)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/807288
>
> Title:
> wishlist: Naming hot cues
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> I have noticed that the songs can already be cued, and I was thinking
> that it would be a great idea to have naming of each hot cue in the
> song. I see this as a very interesting feature because I think this
> could be used to identify mixing points within a song and make it very
> easy to mix.
>
> Thank you!!
> jaime11
>
> Posts: 2
> Joined: Wed Jul 06, 2011 6:00 pm
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/807288/+subscriptions
>

I agree with Be too.

It might spoil the layout the hotcue block.

For the waveform render, I just trunk the label up to n characters. I think I actually implemented this too.
We can just do the same with the hotcue buttons: let them be a little bit bigger to make room for the label, but if the label is too long just trunk it and append ellipsis (...).

For me it is important to add the label to the buttons, because the main waveform just displays a narrow portion of the track. This means that labels of hot cues that are far away from the playback position would not be displayed anywhere (well, maybe the waveform overview, but that can become cluttered easily).
So, if I have a button that jumps to some point of my track and I have a name for that point of the track, I would like that name to appear on the button so I can see where I am jumping before pressing it :)

I have to tell you that this is also part of a proposal for GSOC I'm writing myself. I hope you understand I'm not going to share my mock-ups yet :)
Don't worry about the code, though: it's something I wrote time ago and the less I can do for fair play is share it with you. As I said I'll try to refactor it a little soon and make it available to you.

I think the numbered hotcue buttons should stay as they are and we should come up with a better way to display the whole list of named hotcues. Perhaps truncated labels would be appropriate on the overview waveform.

Hey Kartik,

this commit is where I implemented the solution, take a look and don't hesitate to ask for help.

https://github.com/mixxxdj/mixxx/commit/70f3c4c144c66e019bbace9e88f31555dd9c388d

How is this fixed? There's no interface to name hot cues.

https://mixxx.org/manual/2.1/en/chapters/user_interface.html#hotcue-labels

Oooohkay, cool!
I rarely use that window for editing comments, must have missed it

The properties editor works, but is is pretty awkward to use for that task imo.
The established standard in most other dj applications are list widget for hotcues, that allow to set, clear, color code, and label the hotcue. Something i would love to see in Mixxx too.
See lp:1367171

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5948