Mixxx

DEBUG ASSERT (2) in effects_refactoring branch

Bug #1948540 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
High
Unassigned
Mixxx 2.4.0

Bug Description

I see this as start up:

critical[Main] DEBUG ASSERT: "m_registeredEffects.contains(effectId)" in function virtual EffectManifestPointer BuiltInBackend::getManifest(const QString&) const at /home/daniel/workspace/i18n/src/effects/backends/builtin/builtinbackend.cpp:91

This happens if an configured effect is no longer enabled for some reasons.

Revision history for this message
Be (be.ing) wrote :

Please elaborate how to reproduce this.

Changed in mixxx:
status: New → Incomplete
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I was able to reproduce it by de-installing an LV2 plugin. However this was nothing I have done in the first place. So I guess there must be something else wrong.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Got it. The issue is that EffectPresetManager::loadDefaultEffectPresets tries to create a preset for every file it finds in the directory. In case of an non existing effect, it has a preset with a null manifest, causing the assertion. This can be fixed by only looking up files for existing effecs.

Changed in mixxx:
status: Incomplete → Confirmed
milestone: none → 2.4.0
importance: Undecided → High
Revision history for this message
Be (be.ing) wrote :

What is the solution? Log a warning instead of an assertion?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

The issue is that all the sorrounding code is not aware of a failure.
This applies to the string for the backend in the same way.
There we must add some extra null checks and than we can finally remove the assertion.
I didn't not think we need a warning at all.

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10582

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.