Mixxx

cue preview does not work when jumping

Bug #1903002 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
High
Jan Holthuis

Bug Description

When pressing a loop cue button the track seeks to the loop and starts playing.
When releasing the button it continues "sometimes" to play.
I have the impression that it only happnes if the track have been seeked forward to the loop.
This was tested with LateNigt and Shade skin and current main branch.

Daniel Schürmann (daschuer)
Changed in mixxx:
importance: Undecided → High
Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

Looks like sometimes m_iCurrentlyPreviewingHotcues is not incremented properly.

 void CueControl::hotcueActivatePreview(HotcueControl* pControl, double value) {
+ qWarning() << "CueControl::hotcueActivatePreview" << value << m_iCurrentlyPreviewingHotcues;
     QMutexLocker lock(&m_mutex);
     if (!m_pLoadedTrack) {
         return;

warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 0

Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

Found a pretty easy way to reproduce:

1. Start previewing a hotcue using the mouse
2. Start previewing the same hotcue using the keyboard or a controller
3. Release both in no particular order

Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

Please test https://github.com/mixxxdj/mixxx/pull/3267.

Changed in mixxx:
assignee: nobody → Jan Holthuis (holthuis-jan)
milestone: none → 2.4.0
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

I can also reproduce the issue with regular cues on the 2.3 branch, so has not been caused by PR #2194. Nonetheless, PR #3267 fixes an issue introduced by the saved loops feature and should be merged anyway.

Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

Here's a little Demo on the 2.3 branch: https://www.youtube.com/watch?v=lyUa2JhRRps

Daniel Schürmann (daschuer)
Changed in mixxx:
milestone: 2.4.0 → 2.3.0
summary: - loop cue preview does not work when jumping
+ cue preview does not work when jumping
Daniel Schürmann (daschuer)
Changed in mixxx:
milestone: 2.3.0 → 2.2.5
Jan Holthuis (holthuis-jan)
Changed in mixxx:
status: In Progress → Confirmed
Revision history for this message
Daniel Schürmann (daschuer) wrote :

One Part of the issue is fixed here:
https://github.com/mixxxdj/mixxx/pull/3268

Daniel Schürmann (daschuer)
Changed in mixxx:
milestone: 2.2.5 → 2.3.0
Daniel Schürmann (daschuer)
Changed in mixxx:
milestone: 2.3.0 → none
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10200

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.