Mixxx

Maximize Library steals focus, makes keyboard presses non-working

Bug #1815314 reported by jus
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
ronso0
Mixxx 2.3.0

Bug Description

Tested 2.3.0-alpha-pre (build master r6723)
macOS 10.14.2 (18C54)

Skins affected: Deere, Tango

* Start Mixxx in developer mode
* Load a affected skin
* Load a track to deck 1
* Maximize library, either pressing SPACE bar, or using the dedicated button
* Press the button D to start/stop the track in deck 1

Expected behavior:
* start/stop the track in deck 1
* Log entry : Debug [Main]: keyboard press: "D"

Actual behavior:
* None, the library lost focus. Press TAB key to re-set focus, then pressing D (or any other defined keyboard action) works again.

related:
lp:1259040 Clicking on deck controls affects library keyboard focus
lp:1673196 Controls for Library focus

See original description
Revision history for this message
ronso0 (ronso0) wrote :

The issue is that the we need normal & the maximized libary as two different occurences of a library singleton in Deere & Tango, due to the stacked waveforms that can be hidden/moved.
I tried a few things earlier but couldn't solve this issue from within the skins.

I think of a CO that tracks the library table/tree focus state. This would be helpful also for situations where you clicked on waveforms (library unfocused) and quickly want to use the Trax knob again.

I there a way to emit a signal when widgets pseudo state changes to 'focus'?

related: https://bugs.launchpad.net/mixxx/+bug/1673196

Revision history for this message
ronso0 (ronso0) wrote :

btw the keyboard shortcuts also work again when I click into any overview widget.
maybe it's just that no widget has focus after toggling the swapping the library singletons?

ronso0 (ronso0)
description: updated
Daniel Schürmann (daschuer)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
ronso0 (ronso0) wrote :

If I'm not missing something I think skin.xml of Deere and Tango could both use a WidgetStack to toggle maximized Library, like it works in LateNight. There, the focus jumps to the Sidebar and back to the tracks table when repeatedly toggling [Master],maximize_library, but the shortcuts still work

ronso0 (ronso0)
Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
Revision history for this message
ronso0 (ronso0) wrote :

https://github.com/mixxxdj/mixxx/pull/2289

Changed in mixxx:
milestone: none → 2.3.0
Revision history for this message
ronso0 (ronso0) wrote :

https://github.com/mixxxdj/mixxx/pull/2289 is ready for review.

Testing is very welcome, especially Win and macOS

ronso0 (ronso0)
Changed in mixxx:
status: Confirmed → Fix Committed
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9586

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.