Activity log for bug #1717061

Date Who What changed Old value New value Message
2017-09-13 22:28:15 Brandon Schaefer bug added bug
2017-09-13 22:28:46 Brandon Schaefer branch linked lp:~brandontschaefer/mir/dont-divide-by-zero-miral
2017-09-13 22:32:36 Brandon Schaefer description miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702 miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) How to reproduce: 1) Install a ubuntu core image for the raspi3 http://cdimage.ubuntu.com/ubuntu-core/16/edge/current/ 2) snap install mir-libs --edge 3) snap install mir-kiosk --edge 4) install this snap https://code.launchpad.net/~brandontschaefer/+snap/webkit-demo/+build/75054/+files/mir-kiosk-apps_0.2_amd64.snap 5) snap install mir-kiosk-apps_0.2_amd64.snap --devmode 6) with the mir-kiosk running and the clocks kiosk-app running type: snap set mir-kiosk-apps app=fancybrowser Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702
2017-09-13 22:33:28 Brandon Schaefer description miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) How to reproduce: 1) Install a ubuntu core image for the raspi3 http://cdimage.ubuntu.com/ubuntu-core/16/edge/current/ 2) snap install mir-libs --edge 3) snap install mir-kiosk --edge 4) install this snap https://code.launchpad.net/~brandontschaefer/+snap/webkit-demo/+build/75054/+files/mir-kiosk-apps_0.2_amd64.snap 5) snap install mir-kiosk-apps_0.2_amd64.snap --devmode 6) with the mir-kiosk running and the clocks kiosk-app running type: snap set mir-kiosk-apps app=fancybrowser Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702 miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) How to reproduce: 1) Install a ubuntu core image for the raspi3 http://cdimage.ubuntu.com/ubuntu-core/16/edge/current/ 2) snap install mir-libs --edge 3) snap install mir-kiosk --edge 4) install this snap https://code.launchpad.net/~brandontschaefer/+snap/webkit-demo/+build/73869/+files/mir-kiosk-apps_0.2_armhf.snap 5) snap install mir-kiosk-apps_0.2_amd64.snap --devmode 6) with the mir-kiosk running and the clocks kiosk-app running type:    snap set mir-kiosk-apps app=fancybrowser Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702
2017-09-14 07:11:13 Michał Sawicz description miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) How to reproduce: 1) Install a ubuntu core image for the raspi3 http://cdimage.ubuntu.com/ubuntu-core/16/edge/current/ 2) snap install mir-libs --edge 3) snap install mir-kiosk --edge 4) install this snap https://code.launchpad.net/~brandontschaefer/+snap/webkit-demo/+build/73869/+files/mir-kiosk-apps_0.2_armhf.snap 5) snap install mir-kiosk-apps_0.2_amd64.snap --devmode 6) with the mir-kiosk running and the clocks kiosk-app running type:    snap set mir-kiosk-apps app=fancybrowser Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702 miral-kiosk crashing specificity with a mir-kiosk-apps fancybrowser (or any webkit example) How to reproduce: 1) Install a ubuntu core image for the raspi3 http://cdimage.ubuntu.com/ubuntu-core/16/edge/current/ 2) snap install mir-libs --edge 3) snap install mir-kiosk --edge 4) install this snap https://code.launchpad.net/~brandontschaefer/+snap/webkit-demo/+build/73869/+files/mir-kiosk-apps_0.2_armhf.snap 5) snap install mir-kiosk-apps_0.2_armhf.snap --devmode 6) with the mir-kiosk running and the clocks kiosk-app running type:    snap set mir-kiosk-apps app=fancybrowser Stacktrace: http://paste.ubuntu.com/25523431/ miral logging: http://paste.ubuntu.com/25530436/ qt logging: http://paste.ubuntu.com/25530449/ It seems for unknown reasons in miral::WindowInfo::constrain_resize the ar.width == 0 (pretty sure due to default value). Is getting past the error bit which seems from my read can only happen is the new_size.width < 0. So its pretty much doing 0 - -width * max_uint which will get past the error check. From the logs them selfs I dont see *any* crazy numbers that would cause the width to become negative. A fix is up, and a test that confirms that negative width bit but unsure how it got to be in that state. https://code.launchpad.net/~brandontschaefer/mir/dont-divide-by-zero-miral/+merge/330702
2017-09-14 21:22:58 Brandon Schaefer miral: status New In Progress
2017-09-14 21:23:00 Brandon Schaefer miral: importance Undecided Critical
2017-09-14 21:23:02 Brandon Schaefer miral: assignee Brandon Schaefer (brandontschaefer)
2017-09-14 21:23:13 Brandon Schaefer branch linked lp:~brandontschaefer/miral/fix-unsigned-to-long-overflow
2017-09-15 09:33:40 Alan Griffiths bug task added mir
2017-09-15 09:33:49 Alan Griffiths mir: status New In Progress
2017-09-15 09:33:53 Alan Griffiths mir: importance Undecided Critical
2017-09-15 09:33:56 Alan Griffiths mir: assignee Alan Griffiths (alan-griffiths)
2017-09-15 09:33:58 Alan Griffiths mir: milestone 1.0.0
2017-09-15 09:34:48 Alan Griffiths branch linked lp:~alan-griffiths/mir/fix-1717061
2017-09-15 13:31:52 Alan Griffiths branch linked lp:~alan-griffiths/miral/fix-1717061
2017-09-18 16:38:56 Brandon Schaefer miral: assignee Brandon Schaefer (brandontschaefer)
2017-09-18 16:39:20 Brandon Schaefer miral: assignee Alan Griffiths (alan-griffiths)
2017-09-19 10:45:29 Launchpad Janitor branch linked lp:mir
2017-09-19 10:56:56 Alan Griffiths mir: status In Progress Fix Committed
2017-09-20 09:36:41 Mir CI Bot miral: status In Progress Fix Committed
2017-10-08 14:19:51 Launchpad Janitor branch linked lp:~ci-train-bot/mir/mir-ubuntu-artful-2983
2017-10-11 12:31:01 Launchpad Janitor branch linked lp:~ci-train-bot/mir/mir-ubuntu-artful-2988
2017-10-11 13:35:15 Launchpad Janitor branch linked lp:~ci-train-bot/mir/mir-ubuntu-xenial-2989
2017-10-12 18:11:15 Alan Griffiths mir: status Fix Committed Fix Released