[regression] Windowed clients of nested servers are all black
Bug #1661521 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Critical
|
Kevin DuBois | ||
0.26 |
Fix Released
|
Critical
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[regression] Windowed clients of nested servers are all black
FAILING:
lp:mir r4008
lp:mir/0.26 r4005
WORKING:
Mir 0.26.0 zesty binaries (lp:mir/0.26 r3994)
lp:mir/0.25 r3822
Related branches
lp://staging/~kdub/mir/fix-1661521-0.26.1
- Mir development team: Pending requested
-
Diff: 682 lines (+254/-29)21 files modifiedsrc/client/buffer_factory.cpp (+52/-8)
src/client/buffer_factory.h (+40/-2)
src/client/mir_connection.cpp (+1/-1)
src/include/client/mir/client_buffer_factory.h (+2/-0)
src/platforms/android/client/android_client_buffer_factory.cpp (+9/-0)
src/platforms/android/client/android_client_buffer_factory.h (+3/-0)
src/platforms/eglstream-kms/client/client_buffer_factory.cpp (+10/-0)
src/platforms/eglstream-kms/client/client_buffer_factory.h (+4/-1)
src/platforms/mesa/client/client_buffer.cpp (+24/-0)
src/platforms/mesa/client/client_buffer.h (+4/-0)
src/platforms/mesa/client/client_buffer_factory.cpp (+12/-0)
src/platforms/mesa/client/client_buffer_factory.h (+3/-0)
tests/include/mir/test/doubles/mock_client_buffer_factory.h (+2/-0)
tests/include/mir/test/doubles/stub_client_buffer_factory.h (+7/-0)
tests/mir_test_framework/stub_client_platform_factory.cpp (+11/-0)
tests/unit-tests/client/test_buffer_vault.cpp (+5/-3)
tests/unit-tests/client/test_client_buffer_stream.cpp (+11/-11)
tests/unit-tests/client/test_mir_connection.cpp (+8/-2)
tests/unit-tests/client/test_protobuf_rpc_channel.cpp (+4/-0)
tests/unit-tests/client/test_screencast_stream.cpp (+7/-1)
tests/unit-tests/platforms/mesa/client/test_client_buffer.cpp (+35/-0)
lp://staging/~mir-team/mir/0.26-old
Rejected
for merging
into
lp://staging/mir/ubuntu
- Michał Sawicz: Disapprove
-
Diff: 13 lines (+6/-0)1 file modifieddebian/changelog (+6/-0)
lp://staging/~kdub/mir/fix-1661521
- Chris Halse Rogers: Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 682 lines (+254/-29)21 files modifiedsrc/client/buffer_factory.cpp (+52/-8)
src/client/buffer_factory.h (+40/-2)
src/client/mir_connection.cpp (+1/-1)
src/include/client/mir/client_buffer_factory.h (+2/-0)
src/platforms/android/client/android_client_buffer_factory.cpp (+9/-0)
src/platforms/android/client/android_client_buffer_factory.h (+3/-0)
src/platforms/eglstream-kms/client/client_buffer_factory.cpp (+10/-0)
src/platforms/eglstream-kms/client/client_buffer_factory.h (+4/-1)
src/platforms/mesa/client/client_buffer.cpp (+24/-0)
src/platforms/mesa/client/client_buffer.h (+4/-0)
src/platforms/mesa/client/client_buffer_factory.cpp (+12/-0)
src/platforms/mesa/client/client_buffer_factory.h (+3/-0)
tests/include/mir/test/doubles/mock_client_buffer_factory.h (+2/-0)
tests/include/mir/test/doubles/stub_client_buffer_factory.h (+7/-0)
tests/mir_test_framework/stub_client_platform_factory.cpp (+11/-0)
tests/unit-tests/client/test_buffer_vault.cpp (+5/-3)
tests/unit-tests/client/test_client_buffer_stream.cpp (+11/-11)
tests/unit-tests/client/test_mir_connection.cpp (+8/-2)
tests/unit-tests/client/test_protobuf_rpc_channel.cpp (+4/-0)
tests/unit-tests/client/test_screencast_stream.cpp (+7/-1)
tests/unit-tests/platforms/mesa/client/test_client_buffer.cpp (+35/-0)
description: | updated |
description: | updated |
description: | updated |
Changed in mir: | |
milestone: | none → 1.0.0 |
Changed in mir: | |
assignee: | Daniel van Vugt (vanvugt) → Mir development team (mir-team) |
status: | In Progress → Triaged |
description: | updated |
Changed in mir: | |
assignee: | Mir development team (mir-team) → nobody |
assignee: | nobody → Kevin DuBois (kdub) |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Bisected (on lp:mir). The failure started in:
------- ------- ------- ------- ------- ------- ------- ------- ---- alloca
revno: 4000 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2017-01-30 06:37:42 +0000
message:
mirbuffer: remove MirBufferUsage from buffer allocation. mir_connection_
te_buffer will allocate the formerly-called "software buffer", and there are pla
tform-specific extensions for android and mesa, which allocate the formerly-call
ed 'hardware buffers'.
Approved by mir-ci-bot, Chris Halse Rogers, Cemil Azizoglu, Alan Griffiths. ------- ------- ------- ------- ------- ------- ------- ----
-------