usage of std:call_once in mirclient causes TLS collisions with some android devices
Bug #1599867 reported by
Alberto Aguirre
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
kevin gunn | ||
Mir |
Fix Released
|
Critical
|
Alberto Aguirre | ||
0.23 |
Fix Released
|
Critical
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
usage of std:call_once in src/client/
Related branches
lp://staging/~albaguirre/mir/fix-1599867
- Mir CI Bot: Approve (continuous-integration)
- Cemil Azizoglu (community): Approve
- Kevin DuBois (community): Approve
-
Diff: 23 lines (+1/-11)1 file modifiedsrc/client/error_connections.cpp (+1/-11)
Changed in canonical-devices-system-image: | |
status: | New → In Progress |
importance: | Undecided → Critical |
milestone: | none → 13 |
assignee: | nobody → kevin gunn (kgunn72) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
milestone: | 0.25.0 → 0.24.0 |
no longer affects: | mir/0.24 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Looks like std::call_once is not really required. A static variable initialization has thread safety guarantees under c++11.