Mir

[regression] [testsfail] failure in CI on SimpleDispatchThreadTest.keeps_dispatching_after_signal_interruption

Bug #1441620 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alexandros Frantzis
Mir 0.13.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

11: [ FAILED ] SimpleDispatchThreadTest.keeps_dispatching_after_signal_interruption (860 ms)

failed on CI on a branch that was just modifying the demo code.

https://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-autolanding/493/consoleFull

Related branches

lp://staging/~afrantzis/mir/fix-1441620-simple-dispatch-thread-self-destruction-test
Rejected for merging into lp://staging/mir
Chris Halse Rogers: Needs Information
Kevin DuBois (community): Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Alan Griffiths: Approve
Alberto Aguirre (community): Approve
Diff: 80 lines (+22/-1)
3 files modified
include/common/mir/dispatch/simple_dispatch_thread.h (+4/-0)
src/common/dispatch/simple_dispatch_thread.cpp (+11/-1)
tests/unit-tests/dispatch/test_simple_dispatch_thread.cpp (+7/-0)
lp://staging/~raof/mir/remove-eventloop-self-immolation
Alan Griffiths: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 96 lines (+29/-28)
2 files modified
src/common/dispatch/simple_dispatch_thread.cpp (+8/-2)
tests/unit-tests/dispatch/test_simple_dispatch_thread.cpp (+21/-26)
lp://staging/ubuntu/wily-proposed/mir
Alexandros Frantzis (afrantzis)
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

The problem is actually in the previous test: SimpleDispatchThreadTest.handles_destruction_from_dispatch_callback

From the valgrind trace in CI output:

...
by 0x13997A3: SimpleDispatchThreadTest_handles_destruction_from_dispatch_callback_Test::TestBody() (test_simple_dispatch_thread.cpp:214)
...

SimpleDispatchThreadTest.keeps_dispatching_after_signal_interruption fails because it forks a process which when finished reports all valgrind errors, even if they were caught in the parent process.

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

The cause of the problem is that ~SimpleDispatchThread() detaches the event loop thread when it is called from within that thread. The detached thread will be destroyed at an arbitrary point in the future. In some cases the thread is not yet destroyed when the process is forked in the next test (keeps_dispatching_after_signal_interruption), so valgrind assumes that we have leaked its memory.

Revision history for this message
Kevin DuBois (kdub) wrote :

Sounds like Alexandros has a handle on it, another data point in the hope its helpful: https://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1469/consoleFull

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The code originated in this commit (released in 0.11.0), or one of the changes to it since (scheduled for release in 0.13):

------------------------------------------------------------
revno: 2269 [merge]
author: Christopher James Halse Rogers <email address hidden>, Christopher James Halse Rogers <email address hidden>, Kevin Gunn <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Wed 2015-01-28 06:19:07 +0000
message:
  Add a Dispatchable interface, and transition StreamSocketTransport.
  (LP: #1397375)

  The Dispatchable interface is useful for anything that can provide a monitorable file descriptor. Fixes: https://bugs.launchpad.net/bugs/1397375.

  Approved by PS Jenkins bot, Robert Carr, Alexandros Frantzis, Cemil Azizoglu.
------------------------------------------------------------

summary: - [testsfail] failure in CI on
+ [regression] [testsfail] failure in CI on
SimpleDispatchThreadTest.keeps_dispatching_after_signal_interruption
tags: added: regression
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Whoops. No the test case in question is much newer (new in Mir 0.13):

------------------------------------------------------------
revno: 2381 [merge]
author: Christopher James Halse Rogers <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2015-03-09 22:36:47 +0000
message:
  SimpleDispatchThread: Handle destruction from the dispatch callback.

  Approved by Robert Carr, Kevin DuBois, Andreas Pokorny, PS Jenkins bot.
------------------------------------------------------------

Alexandros Frantzis (afrantzis)
Changed in mir:
status: New → In Progress
importance: Undecided → High
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.13.0
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.