graphics glitch with high resolution clients on SGX android
Bug #1118680 reported by
Kevin DuBois
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Kevin DuBois |
Bug Description
some sort of timing issue present on android with large resolution clients, causes a jittery feel during animations. Present on sgx with large (720p) clients. Jitter can be very slight, or more noticable
Related branches
lp://staging/~kdub/mir/hwc10-support
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Needs Fixing
- Robert Ancell: Approve
-
Diff: 2311 lines (+1064/-439)38 files modifiedinclude/server/mir/graphics/display_buffer.h (+1/-1)
include/test/mir_test_doubles/mock_display_buffer.h (+1/-1)
include/test/mir_test_doubles/mock_fb_hal_device.h (+3/-3)
include/test/mir_test_doubles/mock_hwc_composer_device_1.h (+26/-6)
include/test/mir_test_doubles/mock_hwc_interface.h (+1/-1)
include/test/mir_test_doubles/mock_hwc_organizer.h (+43/-0)
include/test/mir_test_doubles/null_display_buffer.h (+1/-1)
src/server/graphics/android/CMakeLists.txt (+2/-0)
src/server/graphics/android/android_display.cpp (+10/-6)
src/server/graphics/android/android_display.h (+4/-3)
src/server/graphics/android/android_display_factory.cpp (+10/-4)
src/server/graphics/android/android_display_factory.h (+1/-0)
src/server/graphics/android/android_hwc_factory.cpp (+8/-0)
src/server/graphics/android/android_hwc_factory.h (+4/-0)
src/server/graphics/android/default_framebuffer_factory.cpp (+1/-2)
src/server/graphics/android/hwc10_device.cpp (+79/-0)
src/server/graphics/android/hwc10_device.h (+53/-0)
src/server/graphics/android/hwc11_device.cpp (+9/-58)
src/server/graphics/android/hwc11_device.h (+3/-19)
src/server/graphics/android/hwc_common_device.cpp (+97/-0)
src/server/graphics/android/hwc_common_device.h (+72/-0)
src/server/graphics/android/hwc_device.h (+2/-1)
src/server/graphics/android/hwc_display.cpp (+2/-4)
src/server/graphics/android/hwc_display.h (+1/-1)
src/server/graphics/android/hwc_factory.h (+4/-0)
src/server/graphics/gbm/gbm_display_buffer.cpp (+4/-6)
src/server/graphics/gbm/gbm_display_buffer.h (+1/-1)
tests/integration-tests/graphics/android/test_display_integration.cpp (+53/-47)
tests/unit-tests/graphics/android/CMakeLists.txt (+2/-0)
tests/unit-tests/graphics/android/test_android_display_factory.cpp (+38/-26)
tests/unit-tests/graphics/android/test_android_fb.cpp (+7/-1)
tests/unit-tests/graphics/android/test_fb_device.cpp (+1/-1)
tests/unit-tests/graphics/android/test_gpu_display.cpp (+7/-14)
tests/unit-tests/graphics/android/test_hwc10_device.cpp (+161/-0)
tests/unit-tests/graphics/android/test_hwc11_device.cpp (+242/-0)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+80/-197)
tests/unit-tests/graphics/android/test_hwc_display.cpp (+26/-31)
tests/unit-tests/graphics/gbm/test_gbm_display.cpp (+4/-4)
Changed in mir: | |
status: | New → In Progress |
information type: | Proprietary → Public |
Changed in mir: | |
milestone: | none → 0.0.3 |
tags: | added: android |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I explored the possiblity of us having our swapper algorithm or resource possesions wrong. This does not seem to be the case.
The other thing that can cause jitters like this is vsync issues, this is looking to be the more likely culprit.
We don't have HWC vsync support (yet!) in mir. I am exploring how to add this supprot