"Add a Bookmark" button should be "Bookmark This Page"

Bug #782464 reported by John Macdonald
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Confirmed
Undecided
Unassigned

Bug Description

The "Add a Bookmark" button that is in the toolbar by default should be a "Bookmark This Page" button:

1. It is the expected that the button will act on the content (the page) and thus bookmark the current page, not any one. This is also the default behavior in popular browsers. (Chrome, Firefox)

2. Making the "Bookmark This Page" button inactive after bookmarking the page gives feedback to the user that the page was successfully bookmarked. Currently there is no feedback that the page has been bookmarked after bookmarking it from the dialog that appears; the dialog closes and nothing happens. The user may try to bookmark the page again, and they will be able to, making it seem like the page was never bookmarked and the feature does not work (bug #767366). If the button was a "Bookmark This Page" button, it would become inactive after adding the bookmark, giving definite feedback that the page was successfully bookmarked.

3. It simplifies the resulting dialog. This would remove the field that allows for bookmarking a different page than the current one in the dialog, making the ui cleaner and making bookmarking look even more quick and painless.

4. It prevents the user from creating a bookmark that will not work. Users will get the correct URL every time because it will be the URL of the current page; the one they want.

Revision history for this message
Cris Dywan (kalikiana) wrote :

I like the reasoning a lot, albeit I have a concern that

a) bookmarklets with javascirpt: URIs would be harder to create since they aren't real pages
b) you can't create bookmarks of redirecting URLs such as gmail.com.

I guess the Add button in the panel should remain the way it works now, so it can allow for those cases while making the common case more agreeable.

Changed in midori:
status: New → Confirmed
Revision history for this message
John Macdonald (jxtreme42) wrote : Re: [Bug 782464] Re: "Add a Bookmark" button should be "Bookmark This Page"

For bookmarklets, there could be a "Bookmark This Link" option for the link
context menu.

Revision history for this message
Danielle Foré (danrabbit) wrote :

I agree with removing the URL field and such, but this I don't think it'd be possible to make the button insensitive with the current bookmarks system. There is more than just bookmarks in the sidepanel, there is also the bookmarkbar and Speed Dial. So, unless we made all of these hold the same items always...

Revision history for this message
John Macdonald (jxtreme42) wrote :

I don't understand what you're saying, Dan. Does bookmarking a page and
adding it to speed dial not count as a bookmark under the current system?

Revision history for this message
Danielle Foré (danrabbit) wrote :

What I'm saying is that if you bookmark a page and that makes the button insensitive you are now unable to use that button to add the page to your speed dial or to your bookmarks toolbar. Likewise, if we make it insensitive after any one action, it makes the button inaccessible for the other two actions. The only way you could make it insensitive without causing problems is after all three actions had been completed... which is IMO a very unlikely case.

Revision history for this message
John Macdonald (jxtreme42) wrote :

Ok, I understand. Perhaps the button can become an "Edit Bookmark" button
after the page is bookmarked?

Revision history for this message
Danielle Foré (danrabbit) wrote :

Adding a mockup of a simplified dialog :)

Revision history for this message
John Macdonald (jxtreme42) wrote :

I don't quite understand the pop-up menu with "Speed Dial" selected. Does
that determine where the bookmark is "stored"? Can you "check" multiple
entries from that pop-up menu? What's the mental model here?

Michael Moroni (airon90)
tags: added: bookmarks label
Revision history for this message
Cris Dywan (kalikiana) wrote :

The dialog looks like this effectively:

<Website Name>
<speed dial, toolbar, folder1, folder2, folder3>
[x] Run as web app
[Cancel] [Add]

The combo box lets you choose between the speed dial, the toolbar and a folder. Despite technical details these can be seen as exclusive options to the user. If you need more than one of them, open the dialog again. I think this is actually a corner case.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.