Midori segfaults on adding IsraelList to Adblock

It looks like this is a result of the modification date in that list being in the format "06/01/16 10:56". extensions/adblock/updater.vala has logic to check for '-' or '.' separators to find a numeric date string but not '/', and assumes that any string without either of those two characters will have three space-separated fields. This one doesn't, so it crashes.

I'm not sure where one finds detailed documentation on the Adblock list format. We can fix the crash but I don't know which date formats we should actually accept, and whether this block list's date is malformed or correct.

While the specifications don't describe a required format per-say, easylist been very consistent with their date format across all their lists so I think you should reject the line entry rather than parse it. I'll inform the list maintainer about using the correct date-format regardless.

Anyhow, catching exceptions while parsing text files (or any user input really) seems the obvious approach to me regardless ;)

I've raised the issue with the list's maintainer: https://github.com/ABPIsrael/EasyListHebrew/issues/72

The list maintainer fixed the date signature on his end but the bug still persists.

That's to say, when inserting the corrected filter list ( https://raw.githubusercontent.com/ABPIsrael/EasyListHebrew/master/EasyListHebrew.txt ), Midori now won't crush right away and will actually use the filter properly.

However, after closing Midori, when trying to restart it, it segfaults.

So, this one seems a little tricky...