Midori Web Browser

Use Headerbar with GTK+ 3.10 [$40]

Bug #1232558 reported by 982c80311320c1b on 2013-09-28

This bug affects 18 people

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	Fix Released	High	Cris Dywan	Midori Web Browser 0.5.11 "Heads or tails"

Bug Description

Since GNOME and elementary apps move to HeaderBars it would be consistent if Midori would use one, too
See also bug 1254847.

See original description

Tags:

Related branches

lp://staging/~midori/midori/gtk3WebKit2only

On hold for merging into lp://staging/midori

Midori Devs: Pending requested 2014-11-18

lp://staging/~yoseforb/midori/fix-bug1232558

lp://staging/~midori/midori/headerBarSupport

Merged into lp://staging/midori at revision 6961

Paweł Forysiuk: Approve on 2015-06-06

Danielle Foré (community): Approve (ux, testing) on 2015-06-03

Donte Greene (flykidd) on 2013-10-05

Changed in midori:
importance:	Undecided → Low

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-10-12:

How would it be used? We need at least a mockup, the header bars are enirely free-form depending on the app from what I've seen.

Changed in midori:
status:	New → Incomplete
milestone:	none → 0.5.7

Revision history for this message

982c80311320c1b (alexander-wilms) wrote on 2013-10-13:

Basically, it would just be the current toolbar + the close button, roughly like how it's done in Epiphany: https://projects.gnome.org/epiphany/

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-10-13: Re: Use set_titlebar or Headerbar with GTK+ 3.10

Epiphany apparently embeds a toolbar wrapped in a frame without using HeaderBar, instead manually setting margins, a custom close button with "window-close-symbolic" and a SizeGroup for keeping buttons and the entry aligned.

summary:	- Move to Gtk.Headerbar + Use set_titlebar or Headerbar with GTK+ 3.10
Changed in midori:
status:	Incomplete → Confirmed

Revision history for this message

Donte Greene (flykidd) wrote on 2013-11-25:

Also see

*https://developer.gnome.org/gtk3/3.10/GtkHeaderBar.html
* http://elementaryos.org/uploads/content/journal/109--528e96295a974.png
* http://redmine.yorba.org/attachments/2325/geary-start-dev-0.5-headerbar.png
* http://elementaryos.org/journal/the-heuristics-of-headerbars
* http://www.johnstowers.co.nz/blog/static/images/gnome/310.png

Looks awesome.

Revision history for this message

Donte Greene (flykidd) wrote on 2013-11-25:

If Headerbar can change the color of the window, could the Colorful tabs extension possibly change the whole window color with this alongside the tabs?

I assume http://elementaryos.org/uploads/content/journal/109--528e96295a974.png is Birdie doing this.

Revision history for this message

982c80311320c1b (alexander-wilms) wrote on 2013-11-25:

Gnome Contacts changes the Headerbar color when you enable the edit mode: https://wiki.gnome.org/Design/Apps/Contacts

Cris Dywan (kalikiana) on 2013-11-25

description:

updated

Revision history for this message

Cris Dywan (kalikiana) wrote on 2013-12-19:

Proof of concept Edit (701.5 KiB, image/png)

Cris Dywan (kalikiana) on 2013-12-19

Changed in midori:
milestone:	0.5.7 → 0.5.8

Cris Dywan (kalikiana) on 2014-01-23

tags:

added: gtk3.10

Cris Dywan (kalikiana) on 2014-03-02

Changed in midori:
milestone:	0.5.8 → garage

Cris Dywan (kalikiana) on 2014-08-26

Changed in midori:
importance:	Low → High

Cris Dywan (kalikiana) on 2014-12-10

Changed in midori:
assignee:	nobody → Christian Dywan (kalikiana)
milestone:	garage → 0.6.0
status:	Confirmed → In Progress

Revision history for this message

Yosef Or Boczko (yoseforb) wrote on 2015-01-29:

#10

I just created a patch with kinds of fix.
It not really fix, we needs to do what I did for epiphany and geary (and other
apps) - to port the whole toolbar with all the buttons from ToolItem to real
button.

Just before I work on this (it take more time than changes two lines), I wants
to know if it already done in the gtk3webkit2 branch.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2015-01-29:

#11

Yosef, yes, there's already support for that, including some changes to extensions adding custom buttons - it still needs some bug fixes I didn't get to yet, mainly to make sure we can still support a classic toolbar seemlessly for environments that haven't switched to headerbars and where it would look out of place. If you want to help how, I suggest you try the gtk2webkit2 branch and have a look at midori/midori-window.vala which handles this.

Danielle Foré (danrabbit) on 2015-04-30

summary:

- Use set_titlebar or Headerbar with GTK+ 3.10
+ Use Headerbar with GTK+ 3.10

Maxim Taranov (png2378-old-deactivatedaccount) on 2015-05-26

summary:

- Use Headerbar with GTK+ 3.10
+ Use Headerbar with GTK+ 3.10 [$40]

Danielle Foré (danrabbit) on 2015-06-06