Url en/decoding needs to be revised
Bug #1209167 reported by
André Stösel
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Midori Web Browser |
Fix Released
|
High
|
Cris Dywan | ||
Bug Description
Quote gue5t:
...urls like "http://
We also shouldn't ever decode %25 (encoded '%'), because doing so can cause hitting enter in the url bar to change the actual url, e.g. a page which is locally on disk as "get%100.html" would be urlencoded as "get%25100.html" but would request "get%100.html" when the user hits enter in the urlbar after visiting the page.
Related branches
lp://staging/~kalikiana/midori/urlunescaping
- gue5t gue5t: Needs Fixing
-
Diff: 46 lines (+11/-6)2 files modifiedkatze/midori-uri.vala (+6/-6)
tests/magic-uri.c (+5/-0)
lp://staging/~gue5t/midori/urlunescaping-2
- Cris Dywan: Approve
-
Diff: 89 lines (+47/-13)2 files modifiedkatze/midori-uri.vala (+32/-13)
tests/magic-uri.c (+15/-0)
| Changed in midori: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| tags: | added: encoding |
| Changed in midori: | |
| assignee: | nobody → Christian Dywan (kalikiana) |
| milestone: | none → 0.5.6 |
| Changed in midori: | |
| milestone: | 0.5.6 → 0.5.7 |
| Changed in midori: | |
| milestone: | 0.5.7 → garage |
Revision history for this message
| gue5t gue5t (gue5t) wrote | #1 |
| Changed in midori: | |
| status: | Confirmed → In Progress |
| Changed in midori: | |
| status: | In Progress → Fix Committed |
| Changed in midori: | |
| status: | Fix Committed → Fix Released |
| Changed in midori: | |
| milestone: | garage → 0.5.11 |
To post a comment you must log in.
This also breaks duplicating tabs showing these urls; see bug #1350456.