Use "hidden" CSS class instead of setting element.style.display
Bug #808483 reported by
Jonathan Jacobs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Methanal |
Fix Released
|
Medium
|
Jonathan Jacobs | ||
Bug Description
There should never be any reason to twiddle element.
Related branches
lp://staging/~methanal-developers/methanal/808483-use-hidden-style
- Tristan Seligmann: Approve
-
Diff: 322 lines (+29/-126)8 files modifiedmethanal/js/Methanal/Tests/TestUtil.js (+9/-20)
methanal/js/Methanal/Util.js (+8/-15)
methanal/js/Methanal/View.js (+6/-7)
methanal/js/Methanal/Widgets.js (+2/-80)
methanal/themes/methanal-base/methanal-liveform.html (+1/-1)
methanal/themes/methanal-base/methanal-multiselect-input.html (+1/-1)
methanal/themes/methanal-base/methanal-text-input.html (+1/-1)
methanal/themes/methanal-base/methanal-verified-password-input.html (+1/-1)
| Changed in methanal: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| milestone: | none → 0.2.2 |
| Changed in methanal: | |
| status: | Confirmed → Fix Released |
| assignee: | nobody → Jonathan Jacobs (jjacobs) |
| status: | Fix Released → Fix Committed |
| Changed in methanal: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
