comment handling is odd

Bug #1697529 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Merge-o-Matic
Confirmed
Low
Unassigned

Bug Description

I was testing the fix for bug 1686640 where merges without a comment are changed to be printed a different color. While this works it revealed a bug in comment processing - on the test page, https://merges.ubuntu.com/main-new.html, we can see that cdrom-detect is colored as if there is a comment although there is no text there.

Here's the source:

<tr bgcolor=#ff8080 class=first>
<td><tt><a href="c/cdrom-detect/REPORT">cdrom-detect</a></tt>
 <sup><a href="https://launchpad.net/ubuntu/+source/cdrom-detect">LP</a></sup>
 <sup><a href="http://tracker.debian.org/cdrom-detect">PTS</a></sup>
[foundations-bugs]</td>
<td colspan=3><a href='https://launchpad.net/~adconrad'>Adam Conrad &lt;<email address hidden>&gt;</a></td>
<td rowspan=2><form method="get" action="addcomment.py"><br />
<input type="hidden" name="component" value="main" />
<input type="hidden" name="package" value="cdrom-detect" />
<input type="text" style="border-style: none; background-color: #ff8080" name="comment" value="" title="" />
</form></td>
<td rowspan=2>
&nbsp;
</td>
<td rowspan=2>
587
</td>
</tr>
<tr bgcolor=#ff8080>
<td><small>cdrom-detect</small></td>
<td>1.57ubuntu4</td>
<td>1.67</td>
<td>1.57</td>
</tr>

Looking at comments.txt on the server we can see:

cdrom-detect: #861300
cdrom-detect: Debian bug #861300
cdrom-detect:

I'm guessing only the last comment is used and there is no checking for empty data.

Changed in merge-o-matic:
status: New → Confirmed
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.