mediaplayer-app

Media player pauses playback when losing focus

Bug #1518331 reported by James Lewis
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
mediaplayer-app
New
Undecided
Unassigned
mediaplayer-app (Ubuntu)
Confirmed
Low
Unassigned

Bug Description

While testing Unity8 in desktop mode on Nexus 4, "convergence"... I noticed that apps do not get suspended when they are not selected, as they do on the phone... this is great, and required for convergence, obviously. However, the Media Player does stop playing when it loses focus, it appears to pause playback, rather than get suspended depending on focus, so I think this is a flaw in the app, not the system.

See original description
Tags: patch

Related branches

lp://staging/~donquichot2016/mediaplayer-app/pause_focus_fix
Renato Araujo Oliveira Filho (community): Needs Fixing
Diff: 89 lines (+21/-0)
4 files modified
src/CMakeLists.txt (+3/-0)
src/mediaplayer.cpp (+15/-0)
src/mediaplayer.h (+2/-0)
src/qml/player.qml (+1/-0)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, sounds like something that should be fixed for convergence

affects: mediaplayer-app → mediaplayer-app (Ubuntu)
Changed in mediaplayer-app (Ubuntu):
importance: Undecided → Low
Revision history for this message
Bosko (donquichot2016) wrote :

I wrote a small patch for this bug. I have tested it on my computer and it seems to work. But I haven't had the chance to test it on a phone yet.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "pause_focus_fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Bosko: thanks for the patch. It looks pretty decent. One comment I would have immediately is to please try and match the existing C++ code style present. Use the same type of spacing, bracket styling, etc. You are also welcome to branch the mediaplayer source tree and propose a merge request via Launchpad against trunk. Find the trunk branch at lp:mediaplayer-app

summary: - Media player pauses playback when loosing focus
+ Media player pauses playback when losing focus
description: updated
Revision history for this message
Bosko (donquichot2016) wrote :

Thanks for your quick reply. I change the formatting and proposed a merge. I'm unfamiliar with Launchpad, so I hope I did that correctly.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Bosko: I've asked Renato to take a look at your MR. Look for his review comments shortly.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in mediaplayer-app (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.