protocol_access_mapping and backup_protocol_access_mapping can't be customized
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Low
|
Takashi Kajinami |
Bug Description
Description
===========
The protocol_
These options are supposed to allow multiple protocols per single access type, but currently this can't be defined in config file, mainly because current definition of these options makes oslo.config treats values in the dict as a flat string.
Steps to reproduce
==================
1. Add the following definitions in manila.conf
[DEFAULT]
backup_
or
[DEFAULT]
backup_
Expected result
===============
The given values are properly parsed.
Actual result
=============
The dict values are not parsed as list and causes logic error
Environment
===========
This issue was initially found in master but affects older stable branches
Logs & Configs
==============
Changed in manila: | |
importance: | Undecided → Medium |
Changed in manila: | |
importance: | Medium → Undecided |
importance: | Undecided → Low |
Changed in manila: | |
status: | New → Triaged |
When backup_ protocol_ access_ mapping I see protocol_ access_ mapping = {'ip': ['nfs']} log_opt_values /usr/lib/ python3. 9/site- packages/ oslo_config/ cfg.py: 2602
```
2023-10-06 06:03:00.001 76696 DEBUG manila.service [-] backup_
```
in manila data log when manila-data starts.
Then if I add protocol_ access_ mapping= ip:nfs protocol_ access_ mapping = {'ip': 'nfs'} log_opt_values /usr/lib/ python3. 9/site- packages/ oslo_config/ cfg.py: 2602
```
[DEFAULT]
backup_
```
to manila.conf then the start up log shows
```
2023-10-06 10:38:22.143 71627 DEBUG manila.service [-] backup_
```
If I try the format described in the generated config file protocol_ access_ mapping= ip:['nfs' ] protocol_ access_ mapping = {'ip': "['nfs']"} log_opt_values /usr/lib/ python3. 9/site- packages/ oslo_config/ cfg.py: 2602
```
[DEFAULT]
backup_
```
then this results in
```
2023-10-06 13:53:37.513 71612 DEBUG manila.service [-] backup_
```