NetApp cannot create FlexGroup shares configuring dedup/compression

Bug #2036931 reported by Felipe Rodrigues
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Unassigned

Bug Description

Description
===========
When operating NetApp driver with FlexGroup shares, they cannot be provisioned with
dedup or compression being modified. Suppose the share comes with dedupe/compression enabled,
if the operator is requested disabled, the driver fails while changing it. The same problem
occurs if the share is disabled and the request is to be enabled.

The async client operations used by FlexGroup to manage dedup and compression are using wrongly the "send_request", it is not part more of the object "connection, it is now part of the "self". [1][2][3][4]

[1] https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2337
[2] https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2343
[3] https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2352
[4] https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L2361

Steps to reproduce
==================

A chronological list of steps which will help reproduce the issue you hit:
* Configure a NetApp backend with FlexGroup
* Create a share type with "netapp:dedup" as "False"
* Create a share on the FlexGroup pool with the previous type

Expected result
===============
The share should be created without the dedup.

Actual result
=============
The share is not created, failing during the disabling dedup operation.

Environment
===========
Latest Manila version.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/894900

Changed in manila:
status: New → In Progress
Vida Haririan (vhariria)
tags: added: netapp share-groups
Revision history for this message
Vida Haririan (vhariria) wrote :

See related comments in manila-dalmatian-m2-bugsquash ethercal https://ethercalc.net/o2qsmjpagsfb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/894900
Committed: https://opendev.org/openstack/manila/commit/7d1a66632ea4f1ed519a0a318a97e7444f225c19
Submitter: "Zuul (22348)"
Branch: master

commit 7d1a66632ea4f1ed519a0a318a97e7444f225c19
Author: Felipe Rodrigues <email address hidden>
Date: Thu Sep 21 08:03:47 2023 -0300

    [NetApp] Fix FlexGroup share creation while configuring dedup/compression

    FlexGroup shares cannot modify the dedup and compression fields,
    since the client is wrongly used. This patch fix it by calling
    the method correctly.

    Closes-bug: #2036931
    Change-Id: I57158d6e50e416b9acc2f2431fdbe903687649c4

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 19.0.0.0rc1

This issue was fixed in the openstack/manila 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.