OpenStack Shared File Systems Service (Manila)

fix "873868: NetApp: move split job to end"

Bug #2029467 reported by chuan137
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
chuan137
OpenStack Shared File Systems Service (Manila) epoxy-1

Bug Description

The patch "NetApp: move split job to end" (https://review.opendev.org/c/openstack/manila/+/873868) was developed for fixing the issue "NetApp volume busy on create from snapshot Edit" (https://bugs.launchpad.net/manila/+bug/2007970)

However, it does not work as expected. To reproduce the issue, create a share from a snapshot and check the execution steps on the backend. For example, from NetApp's audit log,

> "Fri Jul 21 11:26:25 2023" stnpa1-02-st051 volume-clone-create Success -
> "Fri Jul 21 11:26:25 2023" stnpa1-02-st051 volume-clone-split-start Success -
> "Fri Jul 21 11:26:25 2023" stnpa1-02-st051 volume-modify-iter Success -

The clone split is started before modifying the volume attributes. As a result, the issue in #2007970 can still happen, namely modifying volume attributes fails because of "Volume busy".

Looks like that the fix in https://review.opendev.org/c/openstack/manila/+/873868/1/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#b1567 overlooked that the split variable can be overridden by the "split" field in provisioning_options.

Best,
Chuan

Tags: netapp
Vida Haririan (vhariria)
tags: added: netpp
tags: added: netapp
removed: netpp
Revision history for this message
chuan137 (chuan137) wrote :

btw, I am working on a fix here, https://github.com/sapcc/manila/pull/124/files

Vida Haririan (vhariria)
Changed in manila:
status: New → In Progress
milestone: none → bobcat-3
Revision history for this message
Vida Haririan (vhariria) wrote :

See additional related discussions at See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-03-15.00.log.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/891569

Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: bobcat-3 → caracal-1
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: caracal-1 → caracal-2
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: caracal-2 → caracal-3
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: caracal-3 → dalmation-1
Revision history for this message
Vida Haririan (vhariria) wrote :

See related comments in manila-dalmatian-m2-bugsquash ethercal https://ethercalc.net/o2qsmjpagsfb

Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: dalmatian-1 → dalmatian-3
Goutham Pacha Ravi (gouthamr)
Changed in manila:
assignee: nobody → chuan137 (chuan137)
Carlos Eduardo (silvacarlose)
Changed in manila:
importance: Undecided → Medium
milestone: dalmatian-3 → dalmatian-rc1
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: dalmatian-rc1 → epoxy-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/891569
Committed: https://opendev.org/openstack/manila/commit/7be1e5e91132ed85f6b44794f8a8fee0fca5d9a7
Submitter: "Zuul (22348)"
Branch: master

commit 7be1e5e91132ed85f6b44794f8a8fee0fca5d9a7
Author: Chuan <email address hidden>
Date: Fri Aug 4 08:14:48 2023 +0800

    NetApp: fix delay clone split when creating share from snapshot (#124)

    When creating share from snapshot, the clone-split job is triggered
    right after volume is created on NetApp. The subsequent tasks on the
    volume might fail because of "Volume busy" error. To prevent this issue,
    we would like to delay the clone split job to the end. This problem was
    addressed before, but the previos fix does not work as expected. Both
    split variable in arguments and split field in provisioning_options
    should be considered, and split argument should take precedence.

    Change-Id: Ic401a919ab96b07866a883b5967962fecc892ff0
    Closes-bug: #2029467

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2024.2)

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/manila/+/932149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2024.2)

Reviewed: https://review.opendev.org/c/openstack/manila/+/932149
Committed: https://opendev.org/openstack/manila/commit/e688506443e46c0313f5ffa79a9c1cac47cf4ee3
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit e688506443e46c0313f5ffa79a9c1cac47cf4ee3
Author: Chuan <email address hidden>
Date: Fri Aug 4 08:14:48 2023 +0800

    NetApp: fix delay clone split when creating share from snapshot (#124)

    When creating share from snapshot, the clone-split job is triggered
    right after volume is created on NetApp. The subsequent tasks on the
    volume might fail because of "Volume busy" error. To prevent this issue,
    we would like to delay the clone split job to the end. This problem was
    addressed before, but the previos fix does not work as expected. Both
    split variable in arguments and split field in provisioning_options
    should be considered, and split argument should take precedence.

    Change-Id: Ic401a919ab96b07866a883b5967962fecc892ff0
    Closes-bug: #2029467
    (cherry picked from commit 7be1e5e91132ed85f6b44794f8a8fee0fca5d9a7)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.