OpenStack Shared File Systems Service (Manila)

NetApp delete snapshot with ongoing clone split

Bug #2025641 reported by Maurice Escher
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
kiran pawar
OpenStack Shared File Systems Service (Manila) dalmatian-1

Bug Description

Hi,

please have a look at:
https://paste.opendev.org/show/820541/

I have Manila Xena with ONTAP 9.10 back end and set netapp:split_clone_on_create to "True".
What happened: a share was created from a snapshot, clone split was ongoing. A snapshot of this share had been created and delete of this snapshot went into above error. All happened within 15 minutes (part of a CI/CD) after share create, clone split was still ongoing.

So the fallback to deferred deletion would not work, because even a simple rename of the snapshot is blocked on the NetApp backend during clone split (busy volume).

Maybe the split job needs to be paused and resumed during this rename? Or the deferred deletion needs another marker, maybe the comment field can be modified or a tag being set?

BR,
Maurice

And please see the related issue https://bugs.launchpad.net/manila/+bug/1960239.

Vida Haririan (vhariria)
tags: added: netapp
Vida Haririan (vhariria)
tags: added: snapshot
Vida Haririan (vhariria)
Changed in manila:
assignee: nobody → Felipe Rodrigues (felipefutty)
status: New → Triaged
milestone: none → bobcat-3
importance: Undecided → Medium
Revision history for this message
Vida Haririan (vhariria) wrote :

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-07-06-15.00.log.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/894637

Changed in manila:
status: Triaged → In Progress
Carlos Eduardo (silvacarlose)
Changed in manila:
assignee: Felipe Rodrigues (felipefutty) → kiran pawar (kpdev)
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: bobcat-3 → caracal-1
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: caracal-1 → caracal-2
Carlos Eduardo (silvacarlose)
Changed in manila:
milestone: caracal-2 → caracal-3
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: caracal-3 → dalmation-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/894637
Committed: https://opendev.org/openstack/manila/commit/7bcf51e962d68c6344662b9ccdc7c63dd2c847b6
Submitter: "Zuul (22348)"
Branch: master

commit 7bcf51e962d68c6344662b9ccdc7c63dd2c847b6
Author: Kiran Pawar <email address hidden>
Date: Tue Sep 12 10:57:56 2023 +0000

    [NetApp] Pause and resume clone split during rename snapshot

    When snpashot are soft deleted i.e. they are renamed if delete fails,
    sometime we face issue in rename operation. This is due to busy
    snapshot clone split operations. So perform rename and then start clone
    split.

    Closes-bug: #2025641
    Change-Id: I1093a610f31f5971bb23b9f89c64f5f129ac2fb9

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/manila/+/921369
Committed: https://opendev.org/openstack/manila/commit/62ad3537c3f4629b08be4382d4c42b9cd54ba8d4
Submitter: "Zuul (22348)"
Branch: master

commit 62ad3537c3f4629b08be4382d4c42b9cd54ba8d4
Author: Kiran Pawar <email address hidden>
Date: Wed Jun 5 09:59:11 2024 +0000

    [Netapp] Fix soft_delete_snapshot get children case

    In soft delete snapshot, after rename, we retrieve snapshot children,
    but instead of renamed snapshot we were looking for earlier named
    snapshot. Fixed this.

    Closes-bug: #2025641
    Change-Id: I0577153fe8b2abf1aa521b61754788f2666a3e0f

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 19.0.0.0rc1

This issue was fixed in the openstack/manila 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.