reset replica state not forbidden for active replica

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-04-06-15.00.log.htm

Hi,

Commenting back here to retain the "low-hanging-fruit" tag on this bug. In the fix, the code must check if the reset_replica_state action is being run against an "active" replica.

In https://review.opendev.org/c/openstack/manila/+/857980/3/manila/api/openstack/wsgi.py#1267 ; we're introducing a "get" operation in the mix, so we'd have the data to verify the existing replica_state; so we'd need to add the following validation:

  if (status_attr == 'replica_state'
          and resource['replica_state'] == constants.REPLICA_STATE_ACTIVE):
     msg = _("Cannot reset replica_state of active replica")
     raise webob.exc.HTTPBadRequest(explanation=msg)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/899320

created a fix at https://review.opendev.org/c/openstack/manila/+/899320

Reviewed: https://review.opendev.org/c/openstack/manila/+/899320
Committed: https://opendev.org/openstack/manila/commit/b7a1b5b2cf765b1570432b67363905251893ce42
Submitter: "Zuul (22348)"
Branch: master

commit b7a1b5b2cf765b1570432b67363905251893ce42
Author: Gray Lutalo <email address hidden>
Date: Wed Oct 25 22:33:30 2023 +0000

    Forbid resetting state of active replicas

    In a replication setup, users encountered a critical
    issue where they unintentionally reset the replica_state
    of an active replica while attempting to resolve errors
    on a non-active replica. This led to a situation with no
    active replica, causing data loss. Users expected
    server-side validation to prevent such actions.

    This commit implements the necessary validation in the
    codebase to ensure that the reset_replica_state action
    cannot be applied to active replicas, addressing the
    reported issue and improving data integrity in
    replication setups.

    Co-Authored-By: Solly <email address hidden>
    Closes-Bug: #2015328
    Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/912743

Reviewed: https://review.opendev.org/c/openstack/manila/+/912743
Committed: https://opendev.org/openstack/manila/commit/d5baad9e2f90bba2831e27ad7c508313e803a84b
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit d5baad9e2f90bba2831e27ad7c508313e803a84b
Author: Gray Lutalo <email address hidden>
Date: Wed Oct 25 22:33:30 2023 +0000

    Forbid resetting state of active replicas

    In a replication setup, users encountered a critical
    issue where they unintentionally reset the replica_state
    of an active replica while attempting to resolve errors
    on a non-active replica. This led to a situation with no
    active replica, causing data loss. Users expected
    server-side validation to prevent such actions.

    This commit implements the necessary validation in the
    codebase to ensure that the reset_replica_state action
    cannot be applied to active replicas, addressing the
    reported issue and improving data integrity in
    replication setups.

    Co-Authored-By: Solly <email address hidden>
    Closes-Bug: #2015328
    Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f
    (cherry picked from commit b7a1b5b2cf765b1570432b67363905251893ce42)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/912744

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.

Reviewed: https://review.opendev.org/c/openstack/manila/+/912744
Committed: https://opendev.org/openstack/manila/commit/fc5c241a62105b83825c60cbc8c0ccdea1313bf8
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit fc5c241a62105b83825c60cbc8c0ccdea1313bf8
Author: Gray Lutalo <email address hidden>
Date: Wed Oct 25 22:33:30 2023 +0000

    Forbid resetting state of active replicas

    In a replication setup, users encountered a critical
    issue where they unintentionally reset the replica_state
    of an active replica while attempting to resolve errors
    on a non-active replica. This led to a situation with no
    active replica, causing data loss. Users expected
    server-side validation to prevent such actions.

    This commit implements the necessary validation in the
    codebase to ensure that the reset_replica_state action
    cannot be applied to active replicas, addressing the
    reported issue and improving data integrity in
    replication setups.

    Co-Authored-By: Solly <email address hidden>
    Closes-Bug: #2015328
    Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f
    (cherry picked from commit b7a1b5b2cf765b1570432b67363905251893ce42)
    (cherry picked from commit d5baad9e2f90bba2831e27ad7c508313e803a84b)

This issue was fixed in the openstack/manila 16.2.1 release.

This issue was fixed in the openstack/manila 17.3.0 release.