OpenStack Shared File Systems Service (Manila)

Misuse of assertTrue

Bug #1989250 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Takashi Natsume
OpenStack Shared File Systems Service (Manila) zed-rc1

Bug Description

There are some misuse of assertTrue in the master (commit a1730ea8a6f0a7b2cfe5f09bfc0a06c24dc75a7c).

manila/tests/scheduler/filters/test_json.py:273

        self.assertTrue(self.filter.host_passes, (host, filter_properties))

manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py:156-157

        self.assertTrue(self.library._cluster_info['nve_support'],
                        fake.CLUSTER_NODES)

Takashi Natsume (natsume-takashi)
Changed in manila:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/856898

Changed in manila:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Low
milestone: none → zed-rc1
summary: - Misuse of asserTrue
+ Misuse of assertTrue
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/856898
Committed: https://opendev.org/openstack/manila/commit/c8c4989d43a317fe485ec1796fabb3f49dd6e758
Submitter: "Zuul (22348)"
Branch: master

commit c8c4989d43a317fe485ec1796fabb3f49dd6e758
Author: Takashi Natsume <email address hidden>
Date: Sat Sep 10 20:49:43 2022 +0900

    Fix misuse of assertTrue

    Change-Id: Ic3d3d32c3f7d624846f644601ee1ca01a103882a
    Closes-Bug: 1989250
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.0.0.0rc1

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/863274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila/+/863274
Committed: https://opendev.org/openstack/manila/commit/74928a3afdb26205069c9cbcc0ea52cceaf560db
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 74928a3afdb26205069c9cbcc0ea52cceaf560db
Author: Takashi Natsume <email address hidden>
Date: Sat Sep 10 20:49:43 2022 +0900

    Fix misuse of assertTrue

    Change-Id: Ic3d3d32c3f7d624846f644601ee1ca01a103882a
    Closes-Bug: 1989250
    Signed-off-by: Takashi Natsume <email address hidden>
    (cherry picked from commit c8c4989d43a317fe485ec1796fabb3f49dd6e758)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 14.0.1

This issue was fixed in the openstack/manila 14.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.