OpenStack Shared File Systems Service (Manila)

Manila Provide Share Server Method Is Not Ignoring Error Server

Bug #1978962 reported by Felipe Rodrigues on 2022-06-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Felipe Rodrigues	OpenStack Shared File Systems Service (Manila) zed-3

Bug Description

Description
===========
During share server creation phase, the method that collects all servers available to be sent to the driver (share_server_get_all_by_host_and_share_subnet_valid) is not ignoring the error share servers. As result, the driver can end up selecting an error server to be reused by the share creation.

Steps to reproduce
==================

1. Create a share that ends up creating a server in the error state for any some reason
2. Try to create a share again. It wont try to create a new servers, it will reuse the server in error state.

Expected result
===============

Error share servers must be ignored.

Actual result
=============

Error share servers are sent down to drivers to be reused.

Environment
===========

Master Manila (Since yoga release)

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-06-16: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/846185

Changed in manila:
status:	New → In Progress

Vida Haririan (vhariria) on 2022-06-16

Changed in manila:
assignee:	nobody → Felipe Rodrigues (felipefutty)
importance:	Undecided → Medium
milestone:	none → zed-2

Revision history for this message

Vida Haririan (vhariria) wrote on 2022-06-16:

See additional information at https://meetings.opendev.org/meetings/manila/2022/manila.2022-06-16-15.00.log.html

Carlos Eduardo (silvacarlose) on 2022-07-28

Changed in manila:
milestone:	zed-2 → zed-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-08-30: Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/846185
Committed: https://opendev.org/openstack/manila/commit/8dc6235b5f2c063c446a9e99c4bfe9048742a25a
Submitter: "Zuul (22348)"
Branch: master

commit 8dc6235b5f2c063c446a9e99c4bfe9048742a25a
Author: Felipe Rodrigues <email address hidden>
Date: Thu Jun 16 12:11:27 2022 -0300

Fix available share servers to be reused

    The change [1] modified the function
    `share_server_get_all_by_host_and_share_subnet_valid` adding the
    status option. However, it removed the actual filter from the query
    wrongly. As result, the method is returning all share servers without
    taking the status in account.

This patch reverts that change and also creating a new one for
collecting all share servers no matter their states.

[1] https://review.opendev.org/c/openstack/manila/+/825110

Closes-Bug: #1978962
Change-Id: I8d9437eafde67407ba5e337dd495fdb74eefec70

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-08-30: Fix proposed to manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/855005

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-12: Fix merged to manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila/+/855005
Committed: https://opendev.org/openstack/manila/commit/60fd8ab607f558c52347508bf768e9384af529c1
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 60fd8ab607f558c52347508bf768e9384af529c1
Author: Felipe Rodrigues <email address hidden>
Date: Thu Jun 16 12:11:27 2022 -0300

Fix available share servers to be reused

This patch reverts that change and also creating a new one for
collecting all share servers no matter their states.

[1] https://review.opendev.org/c/openstack/manila/+/825110

    Closes-Bug: #1978962
    Change-Id: I8d9437eafde67407ba5e337dd495fdb74eefec70
    (cherry picked from commit 8dc6235b5f2c063c446a9e99c4bfe9048742a25a)