OpenStack Shared File Systems Service (Manila)

extend share scheduler filters should be configurable

Bug #1973621 reported by Maurice Escher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
kiran pawar
OpenStack Shared File Systems Service (Manila) zed-3

Bug Description

Hi,

when using the scheduler filters during share extend, only some of them make sense to me.

To speed up scheduling and to prevent from weird errors, I want to be able to define a default list of filters to use (similar to scheduler_default_share_group_filters I would like to have a scheduler_default_extend_filters option)

E.g. in the simplest case having CapacityFilter for share extend may be enough.

Do you agree on the usefulness?

BR,
Maurice

Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Hi Maurice,

We discussed this at the manila weekly IRC meeting and we're in general agreement about this. Is this something you'd like to propose?

I want to know your thoughts on default filters - does it make sense to have an empty default and allow overrides?

Also, would you be interested in creating this config opt/behavior?

Thanks,
Goutham

Changed in manila:
importance: Undecided → Medium
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Additional comments: https://meetings.opendev.org/meetings/manila/2022/manila.2022-05-26-15.00.log.html#l-134

Revision history for this message
Maurice Escher (maurice-escher) wrote :

I have not started working on this - anyone feel free to grab this ;)

I would think having the CapacityFilter configured by default, would make sense.

The possibility to set en empty list of filters on extend would make the result of extend the same like extend with 'force' option. That could be useful, but I don't think this should be the default.

Revision history for this message
Vida Haririan (vhariria) wrote :

See additional discussions at https://meetings.opendev.org/meetings/manila/2022/manila.2022-06-02-15.00.log.html

Changed in manila:
assignee: nobody → Felipe Rodrigues (felipefutty)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/853425

Changed in manila:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: none → zed-3
assignee: Felipe Rodrigues (felipefutty) → kiran pawar (kpdev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/853425
Committed: https://opendev.org/openstack/manila/commit/281788715b618384168e69b1c1e5b17b10e37bb3
Submitter: "Zuul (22348)"
Branch: master

commit 281788715b618384168e69b1c1e5b17b10e37bb3
Author: Kiran Pawar <email address hidden>
Date: Wed Aug 17 10:21:21 2022 +0000

    Add scheduler_default_extend_filters option.

    Instead of using all default filters of share create operation, use only
    necessary list of filters for share extend operation. A new config
    option `scheduler_default_extend_filters` is added to provide such list
    of filters e.g. CapacityFilter.

    Closes-Bug: #1973621
    Change-Id: I162325f3096227b74a58b9a55de4660668454d4b

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.0.0.0rc1

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.