NetApp: thin provisioning is not enabled unless the extra spec is defined in share types

Bug #1970649 reported by Vida Haririan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Triaged
Medium
Felipe Rodrigues

Bug Description

Description:

When a share is created with the sare type without the thin_provisioning spec, Manila ENABLES thin provisioning automatically.

 https://github.com/openstack/manila/blob/9e277158acf5fbf0bab954cf46f6f56bf1ef3b84/manila/scheduler/filters/capacity.py#L80
 https://github.com/openstack/manila/blob/9e277158acf5fbf0bab954cf46f6f56bf1ef3b84/manila/scheduler/utils.py#L86-L118

On the other hand, When NetApp driver determines the options used to creates a new share in the backend storage, it considers thin provisioning is DISABLED if the spec is not defined in the share type.

 https://github.com/openstack/manila/blob/9e277158acf5fbf0bab954cf46f6f56bf1ef3b84/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L69-L75
 https://github.com/openstack/manila/blob/9e277158acf5fbf0bab954cf46f6f56bf1ef3b84/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L752-L753
 https://github.com/openstack/manila/blob/9e277158acf5fbf0bab954cf46f6f56bf1ef3b84/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L645-L648

Because of this inconsistency, when a share requires overcommit, the capacity filter can select the backend(because thin provisioning is enabled) while the backend storage doesn't allow creating new shares(because thin provisioning is disabled)

Version-Release number of selected component (if applicable):

How reproducible:
Always

Steps to reproduce:
1. Create a share type without thin_provisioning extra spec
2. Create shares to allocate all capacity
3. Create a new share

Expected result:
Share creation should succeed

Actual results:
Share creation fails because manila-scheduler can't create the new share in the backend

Tags: netapp
Vida Haririan (vhariria)
tags: added: netapp
Revision history for this message
Vida Haririan (vhariria) wrote :
Changed in manila:
assignee: nobody → Felipe Rodrigues (felipefutty)
importance: Undecided → Medium
Vida Haririan (vhariria)
Changed in manila:
status: New → Triaged
Revision history for this message
Vida Haririan (vhariria) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.