coverage job fails even without any code changes

Bug #1797512 reported by Goutham Pacha Ravi
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)

Bug Description

The coverage test (tox -e cover) sometimes fails even without any code changes being committed.

Example Failure:
Review in question:
Console Log file attached with this report.

Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :
Changed in manila:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to manila (master)

Submitter: Zuul
Branch: master

commit a07c51e8b01074d8ee8bb936a31ad4c1654c4e73
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Oct 11 15:00:07 2018 -0700

    Make coverage non-voting and fix use of rpc_backend

    rpc_backend was an old oslo_messaging option
    that was deprecated in stable/newton and removed
    in master/stein [2], so stop using it in our
    unit tests.

    The coverage job in manila was always non-voting,
    however, a773e31420bfd141682c43d0823d2009078c2fec
    added a common coverage job-template from the
    openstack-zuul-jobs repository. This change
    inadvertently made the non-voting cover job a
    voting job.

    Our coverage script isn't perfect, it is known
    to fail erroneously on non-code changes, and
    some genuine failures are just an indication
    to developers and reviewers to make the best
    effort to adhere to the script's strict
    checks [3].

    These changes are unrelated, but must be fixed
    together to pass the gate, since we have a
    chicken-and-egg problem with both failures
    preventing separate fixes from merging


    Closes-Bug: #1796759
    Related-Bug: #1797512
    Change-Id: Ie349c3866d51ea4e706369ad67bc1155f62f2651

Revision history for this message
Jason Grosso (jgrosso) wrote :

since the job is non-voting, reviewers may take a call to ignore coverage failure

Changed in manila:
importance: Medium → Wishlist
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.